Implement new readonly (getter only) property of ErrorProvider.HasErrors - #6234
Merged
dreddy-work merged 7 commits intoDec 15, 2021
Merged
Conversation
eriawan
changed the title
Member
Author
|
@RussKie |
RussKie
added
the
waiting-author-feedback
Member
Author
|
@RussKie I'm going to add unit tests for this new |
ghost
removed
the
waiting-author-feedback
Member
Author
|
unit tests added. please review, thanks in advance 🙂 |
RussKie
reviewed
Dec 1, 2021
ghost
added
the
waiting-author-feedback
ghost
removed
the
waiting-author-feedback
…ace should not be preceded by a blank line"
…rorProvider.Clear()
RussKie
reviewed
Dec 2, 2021
…r.cs Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
RussKie
previously approved these changes
Dec 2, 2021
Member
Author
|
@RussKie |
Contributor
|
@eriawan - no, I don't think so. @dreddy-work will review and merge this PR, once he's ready. |
RussKie
added
the
waiting-on-team
dreddy-work
reviewed
Dec 13, 2021
dreddy-work
added
waiting-author-feedback
ghost
removed
the
waiting-author-feedback
dreddy-work
added
the
waiting-author-feedback
…ublicAPI.Unshipped.txt
ghost
removed
the
waiting-author-feedback
dreddy-work
approved these changes
Dec 15, 2021
Member
Author
|
Thanks! |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5912
Proposed changes
Customer Impact
Regression?
Risk
Screenshots
Before
After
Test methodology
Accessibility testing
Test environment(s)
Microsoft Reviewers: Open in CodeFlow