Add missing feasible file and folder dialog options

[willibrandon]

Fixes #5405

Proposed changes

Add missing feasible file and folder dialog options and expose them via public properties.

• AddToRecent
• CheckWriteAccess
• ExpandedMode
• OkRequiresInteraction
• SelectReadOnly
• ShowHiddenFiles
• ShowPinnedPlaces
• ShowPreview

namespace System.Windows.Forms
{
    public partial class FileDialog
    {
        [DefaultValue(true)]
        public bool AddToRecent { get; set; } = true;

        [DefaultValue(false)]
        public bool ShowHiddenFiles { get; set; }

        [DefaultValue(true)]
        public bool ShowPinnedPlaces { get; set; } = true;

        [DefaultValue(false)]
        public bool OkRequiresInteraction { get; set; }
    }

    public partial class OpenFileDialog
    {
        [DefaultValue(false)]
        public bool ShowPreview { get; set; }

        [DefaultValue(true)]
        public bool SelectReadOnly { get; set; } = true;
    }

    public partial class SaveFileDialog
    {
        [DefaultValue(true)]
        public bool ExpandedMode { get; set; } = true;

        [DefaultValue(true)]
        public bool CheckWriteAccess { get; set; } = true;
    }

    public partial class FolderBrowserDialog
    {
        [DefaultValue(true)]
        public bool AddToRecent { get; set; } = true;

        [DefaultValue(false)]
        public bool ShowHiddenFiles { get; set; }

        [DefaultValue(true)]
        public bool ShowPinnedPlaces { get; set; } = true;

        [DefaultValue(false)]
        public bool OkRequiresInteraction { get; set; }
    }
}

Customer Impact

• Improved file and folder dialog experience.

Regression?

• No.

Risk

• I could use some guidance analyzing the risk for this change.
• I don't know if I've included everything that is necessary for the VS Designer to support this feature.

Videos

AddToRecent

Gets or sets a value indicating whether the dialog box adds the folder being selected to the recent list.

AddToRecent.mp4

CheckWriteAccess

Gets or sets a value indicating whether the dialog box verifies whether creation of the specified file will be successful. If this flag is not set, the calling application must handle errors, such as denial of access, discovered when the item is created.

TestFileCreate.mp4

ExpandedMode

Gets or sets a value indicating whether the dialog box is always opened in the expanded mode.

ExpandedMode.mp4

OkRequiresInteraction

Gets or sets a value indicating whether the OK button of the dialog box is disabled until the user navigates the view or edits the filename (if applicable). Note: Disabling of the OK button does not prevent the dialog from being submitted by the Enter key.

OkButtonNeedsInteraction.mp4

SelectReadOnly

Gets or sets a value indicating whether the dialog box allows to select read-only files.

ReadOnlyReturn.mp4

ShowHiddenFiles

Gets or sets a value indicating whether the dialog box displays hidden and system files.

ForceShowHidden.mp4

ShowPinnedPlaces

Gets or sets a value indicating whether the items shown by default in the view's navigation pane are hidden.

HidePinnedPlaces.mp4

ShowPreview

Gets or sets a value indicating whether the dialog box shows a preview for selected files.

ForcePreviewPaneOn.mp4

Test methodology

• Added unit tests.
• Manually tested the changes using WinformsControlsTest -> Dialogs Test (see videos).
• Ran unit and integration tests.

Accessibility testing

Accessibility Insights for Windows

I'm seeing FastPass automated check failures for the FolderBrowserDialog, OpenFileDialog, and SaveFileDialog prior to making this change. Based on my tests this change does not increase the number of failures detected.

Test environment(s)

• Windows 10.0.22000
• .NET Core SDK 6.0.100

Microsoft Reviewers: Open in CodeFlow

[RussKie]

👍

[dreddy-work]

LGTM.

[dreddy-work]

Thank you @willibrandon .