Skip to content

Document updated anchor calculations in .NET 8.0 - #7985

Merged
dreddy-work merged 12 commits into
mainfrom
dev/dreddy/UpdateDocAnchorLayout
Nov 2, 2022
Merged

Document updated anchor calculations in .NET 8.0#7985
dreddy-work merged 12 commits into
mainfrom
dev/dreddy/UpdateDocAnchorLayout

Conversation

@dreddy-work

@dreddy-work dreddy-work commented Oct 21, 2022

Copy link
Copy Markdown
Member

Related to #7956.

Documenting the updated Anchor calculations in .NET 8.0 for future reference.

Microsoft Reviewers: Open in CodeFlow
@dreddy-work
dreddy-work requested a review from a team as a code owner October 21, 2022 17:49
@ghost ghost assigned dreddy-work Oct 21, 2022
@dreddy-work dreddy-work changed the title Document updated AnchorCalculation in .NET 8.0 Oct 21, 2022
@dreddy-work dreddy-work changed the title Document updated anchor calculation in .NET 8.0 Oct 21, 2022
Comment thread docs/AnchorLayoutChangesInNet80.md Outdated
Comment thread docs/AnchorLayoutChangesInNet80.md Outdated
Comment thread docs/AnchorLayoutChangesInNet80.md Outdated
Comment thread docs/AnchorLayoutChangesInNet80.md Outdated
Comment thread docs/AnchorLayoutChangesInNet80.md Outdated
Comment thread docs/AnchorLayoutChangesInNet80.md Outdated
Comment thread docs/AnchorLayoutChangesInNet80.md Outdated
Comment thread docs/AnchorLayoutChangesInNet80.md Outdated
Comment thread docs/AnchorLayoutChangesInNet80.md Outdated
Comment thread docs/AnchorLayoutChangesInNet80.md Outdated
Comment thread docs/AnchorLayoutChangesInNet80.md Outdated
@ghost ghost added waiting-author-feedback The team requires more information from the author and removed waiting-author-feedback The team requires more information from the author labels Oct 24, 2022
@dreddy-work
dreddy-work requested a review from RussKie October 24, 2022 02:50
Comment thread docs/AnchorLayoutChangesInNet80.md Outdated
Comment thread docs/AnchorLayoutChangesInNet80.md Outdated
Comment thread docs/AnchorLayoutChangesInNet80.md Outdated
Comment thread docs/AnchorLayoutChangesInNet80.md Outdated
Comment thread docs/AnchorLayoutChangesInNet80.md Outdated
Comment thread docs/AnchorLayoutChangesInNet80.md Outdated
Comment thread docs/AnchorLayoutChangesInNet80.md Outdated
Comment thread docs/AnchorLayoutChangesInNet80.md Outdated
Comment thread docs/AnchorLayoutChangesInNet80.md Outdated
Comment thread docs/AnchorLayoutChangesInNet80.md Outdated
Comment thread docs/AnchorLayoutChangesInNet80.md Outdated
Comment thread docs/AnchorLayoutChangesInNet80.md Outdated
Comment thread docs/AnchorLayoutChangesInNet80.md Outdated

@merriemcgaw merriemcgaw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly grammatical suggestions.

@ghost ghost added waiting-author-feedback The team requires more information from the author and removed waiting-author-feedback The team requires more information from the author labels Oct 24, 2022
RussKie
RussKie previously approved these changes Oct 25, 2022

@RussKie RussKie left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff 🚀

Comment thread docs/AnchorLayoutChangesInNet80.md Outdated
Comment thread docs/AnchorLayoutChangesInNet80.md Outdated
Comment thread docs/AnchorLayoutChangesInNet80.md Outdated
Comment thread docs/AnchorLayoutChangesInNet80.md Outdated
Comment thread docs/AnchorLayoutChangesInNet80.md Outdated
Comment thread docs/AnchorLayoutChangesInNet80.md Outdated
@RussKie RussKie added the waiting-author-feedback The team requires more information from the author label Oct 27, 2022
Comment thread docs/AnchorLayoutChangesInNet80.md Outdated
Comment thread docs/design/anchor-layout-changes-in-net80.md Outdated
Comment thread docs/design/anchor-layout-changes-in-net80.md Outdated
Comment thread docs/design/anchor-layout-changes-in-net80.md Outdated
Co-authored-by: Jeremy Kuhne <jkuhne@microsoft.com>
Comment thread docs/design/anchor-layout-changes-in-net80.md Outdated
Comment thread docs/design/anchor-layout-changes-in-net80.md Outdated
Comment thread docs/design/anchor-layout-changes-in-net80.md Outdated
Comment thread docs/design/anchor-layout-changes-in-net80.md Outdated
Comment thread docs/design/anchor-layout-changes-in-net80.md Outdated
Comment thread docs/design/anchor-layout-changes-in-net80.md Outdated
Comment thread docs/design/anchor-layout-changes-in-net80.md Outdated
@RussKie RussKie added the waiting-author-feedback The team requires more information from the author label Nov 2, 2022
@ghost ghost removed the waiting-author-feedback The team requires more information from the author label Nov 2, 2022
@dreddy-work
dreddy-work requested a review from RussKie November 2, 2022 03:38
@dreddy-work
dreddy-work dismissed merriemcgaw’s stale review November 2, 2022 04:20

addressed feedback

Comment thread docs/design/anchor-layout-changes-in-net80.md Outdated
Comment thread docs/design/anchor-layout-changes-in-net80.md Outdated
Comment thread docs/design/anchor-layout-changes-in-net80.md Outdated
Comment thread docs/design/anchor-layout-changes-in-net80.md Outdated
Comment thread docs/design/anchor-layout-changes-in-net80.md Outdated
Comment thread docs/design/anchor-layout-changes-in-net80.md Outdated
@RussKie
RussKie disabled auto-merge November 2, 2022 05:04
Comment thread src/System.Windows.Forms/src/System/Windows/Forms/Layout/DefaultLayout.cs Outdated
@dreddy-work
dreddy-work merged commit 0db7e32 into main Nov 2, 2022
@dreddy-work
dreddy-work deleted the dev/dreddy/UpdateDocAnchorLayout branch November 2, 2022 15:45
@ghost ghost added this to the 8.0 Preview1 milestone Nov 2, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Dec 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

design-discussion Ongoing discussion about design without consensus

5 participants