[main] Update dependencies from dnceng/internal/dotnet-wpf-int#9263
[main] Update dependencies from dnceng/internal/dotnet-wpf-int#9263dipeshmsft merged 1 commit intomainfrom
Conversation
…otnet-wpf-int build 20240619.2 Microsoft.DotNet.Wpf.DncEng From Version 9.0.0-preview.6.24314.2 -> To Version 9.0.0-preview.7.24319.2
![dotnet-policy-service[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/285228?s=60&v=4){kind=small}
dotnet-policy-service
bot
added
the
PR
|
@ViktorHofer do you think we can drop the CoherentParentDependency attribute on the new System.Runtime.Serialization.Formatters package like Maestro suggests? It looks like WinForms doesn't actually use the package - the references in the WinForms repo seem to only come from tests. I'm guessing #9264 is blocked on this now. |
|
The dependency is now already defined in winforms but we need the winforms dependency Update PR for that. So we are in a chicken egg situation right now. I suggest to just merge this PR with the failing coherency check. I don't have permissions though. |
|
@dotnet/wpf-developers main is currently broken (see #9265 that is failing with the same issue as #9264). It seems to be because the CI machines picked up a new Visual Studio and there are some binaries in the build that were built with old Visual Studio. The #9264 PR is on a critical path for the dotnet/sdk repo (dotnet/sdk#41616 (comment)). Could you help us unblock? |
|
@ViktorHofer , so after merging this PR, we need to merge #9264 as well, and after that the issue will be resolved ? From what I see, it looks like #9264 is dependent on this PR. |
|
That's the theory, yes. |
|
PRs against main are currently failing with: and if this update is what it's expected to resolve it (I'd hope it brings fresh builds of these libraries), it needs to be merged or no PR against main can be green. The PR at #9264 has a green coherency check (but has the build break), so that would support the theory that getting both in will fix everything. |
3 participants
This pull request updates the following dependencies
From https://dev.azure.com/dnceng/internal/_git/dotnet-wpf-int
Microsoft Reviewers: Open in CodeFlow