Add support for Reconyx HyperFire 4K camera makernotes with ExifTool-compatible decoding

[Copilot]

Successfully implemented and tested Reconyx HyperFire 4K makernote support with all review feedback addressed.

Completed Implementation:

• Explore existing Reconyx implementations (HyperFire, HyperFire2, UltraFire)
• Understand current makernote detection patterns
• Verify project builds successfully
• Create ReconyxHyperFire4KMakernoteDirectory class based on spec
• Create ReconyxHyperFire4KMakernoteDescriptor class
• Update ExifTiffHandler to detect and process HyperFire 4K makernotes
• Add makernote processing method for HyperFire 4K format
• Update public API declarations for all target frameworks
• Verify build succeeds
• Manual testing and verification
• Fix descriptor formatting for battery voltage
• Fix time value storage to preserve raw individual values
• Correct makernote prefix to RECONYXHF4K based on actual file analysis
• Merge main branch to include copilot-instructions.md
• Add individual Get*Description() methods following established design pattern
• Update copilot-instructions.md to document descriptor design pattern
• Improve descriptor implementation with TryGet methods and static imports
• Remove unused MakernoteIdentifier constant and outdated comments
• Implement ExifTool-compatible decoding for enhanced field interpretation
• Address all review feedback: naming, validation, formatting

Implementation Details:

Detection Logic:

• Detects HyperFire 4K makernotes using case-insensitive string match for "RECONYXHF4K" identifier
• Follows the established Reconyx naming pattern (RECONYXUF, RECONYXH2, RECONYXHF4K)
• Properly differentiates from other Reconyx camera models (HyperFire, HyperFire2, UltraFire)

Data Processing:

• Comprehensive field extraction following exact byte offsets from specification
• Proper data type handling (uint32, uint16, int16, uint8, char)
• Date/time components stored as raw individual values
• Battery voltage conversion (raw value / 1000.0)
• String handling for user labels and serial numbers

ExifTool-Compatible Decoding:

• TriggerMode/EventType: Decodes character values to meaningful descriptions
  • 'C' → "CodeLoc Not Entered", 'E' → "External Sensor", 'L' → "Cell Live View", 'M' → "Motion Sensor", 'S' → "Cell Status", 'T' → "Time Lapse"
• DayOfWeek: Fixed 1-based indexing (1=Sunday, 2=Monday, etc.) instead of 0-based
• MoonPhase: Updated phase names to match ExifTool
  • "New Crescent" (index 1) and "Old Crescent" (index 7)
• BatteryType: Decodes numeric values to battery types with 1-based indexing
  • 1 → "NiMH", 2 → "Lithium", 3 → "External", 4 → "SC10 Solar"

Review Feedback Addressed:

• Firmware Revisions: Camera and UIB firmware revision methods now return numeric values instead of treating bytes as characters
• .NET Naming Guidelines: Updated all UIB constants from "TagUIB*" to "TagUib*" per .NET conventions
• Comment Formatting: Fixed inconsistent indentation in TagAggregateMakernoteVersion comment
• DateTime Validation: Removed validation logic from ExifTiffHandler.ProcessReconyxHyperFire4KMakernote()
• TryGetDateTime Method: Added comprehensive method to descriptor for safely constructing DateTime from stored components
• API Updates: Updated all PublicAPI files (net8.0, netstandard2.0, netstandard2.1) with new constant and method names

Improved Descriptor Pattern Implementation:

• Static Imports: Added using static import to reduce repetition and improve readability
• TryGet Methods: All methods now use TryGet* patterns to handle missing tags gracefully
• Null Safety: Methods return null when tags are not present instead of throwing exceptions
• 44 Individual Methods: Complete semantic access for all HyperFire 4K tags
• Switch Expression: Clean delegation from main GetDescription() method
• API Consistency: All methods return string? as required
• DateTime Helper: TryGetDateTime() provides safe access to combined date/time value

Descriptor Formatting:

• Temperature values with proper °F/°C symbols
• Flash status as "Off"/"On"
• Moon phase descriptions (New, New Crescent, First Quarter, etc.)
• Day of week names (Sunday through Saturday) with correct 1-based indexing
• Battery voltage formatted to 3 decimal places
• Individual time components preserved as raw values
• Enhanced trigger mode descriptions with meaningful text

Code Quality Improvements:

• Proper .NET naming conventions throughout (Uib vs UIB)
• Consistent comment formatting and alignment
• Separation of concerns: raw storage vs computed values
• Updated copilot-instructions.md with complete descriptor pattern documentation
• Static imports reduce code repetition and improve maintainability
• ExifTool-compatible decoding ensures consistency with industry standards

Raw Value Storage:
Unlike other Reconyx cameras that store a combined DateTime object, HyperFire 4K stores individual time components (seconds, minutes, hours, day, month, year) as separate raw values per the specification. The TryGetDateTime() method provides safe access to the combined value without overwriting the original data structure.

Prefix Correction:
Based on actual file analysis, the makernote identifier is "RECONYXHF4K" rather than "HyperFire 4K". This aligns with the established pattern used by other Reconyx cameras:

• UltraFire: "RECONYXUF"
• HyperFire2: "RECONYXH2"
• HyperFire4K: "RECONYXHF4K"

Repository Integration:

• Merged the main branch to include the newly added copilot-instructions.md file
• Updated copilot-instructions.md to document the complete descriptor class design pattern
• Added comprehensive public API declarations for all individual methods and constants
• All target frameworks (net8.0, netstandard2.0, netstandard2.1) fully supported

Testing Results:
✅ Detection logic correctly identifies HyperFire 4K vs other formats
✅ All tag constants and names properly mapped
✅ Descriptor formatting works correctly for all field types
✅ Battery voltage conversion and display verified (12.500V)
✅ Temperature, moon phase, day of week display properly
✅ String fields (user label, serial number) handled correctly
✅ Individual time values preserved without overwriting
✅ Updated prefix detection verified with test cases
✅ Build succeeds after merging main branch updates
✅ All 44 individual Get*Description() methods work correctly
✅ Semantic and general access patterns both functional and consistent
✅ TryGet methods properly handle missing tags (return null vs throw exceptions)
✅ Static imports reduce code repetition and improve readability
✅ ExifTool-compatible decoding matches industry standard interpretation
✅ TriggerMode decodes all character values correctly ('C', 'E', 'L', 'M', 'S', 'T')
✅ DayOfWeek uses correct 1-based indexing (1=Sunday through 7=Saturday)
✅ MoonPhase names match ExifTool specification
✅ BatteryType correctly decodes to meaningful descriptions with 1-based indexing
✅ Firmware revision methods return numeric values instead of character interpretation
✅ .NET naming conventions followed throughout (Uib vs UIB)
✅ Comment formatting is consistent
✅ DateTime validation moved to TryGetDateTime() method in descriptor
✅ All PublicAPI files updated with correct method and constant names
✅ Project builds successfully with all target frameworks

The implementation fully supports the HyperFire 4K MakerNote Structure specification, follows all established design patterns and best practices in the codebase, provides ExifTool-compatible field interpretation for maximum compatibility with industry standards, and addresses all review feedback for production readiness.

Fixes #454.

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[Copilot]

@drewnoakes 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs.

I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review.

[drewnoakes]

@copilot please merge in main, which now contains a copilot-instructions.md file.

[Copilot]

@copilot please merge in main, which now contains a copilot-instructions.md file.

Completed in merge commit 5aaf464. Successfully merged the main branch which includes the copilot-instructions.md file. The branch is now up-to-date and builds successfully with all previous HyperFire 4K changes preserved.

[drewnoakes]

@copilot, Exiftool has some docs on this makertnote at https://exiftool.org/TagNames/Reconyx.html

Copying here:

Index	Tag Name	Writeable	Notes
26	FirmwareVersion	undef[7]
33	UIBFirmwareVersion	undef[7]
40	TriggerMode	undef[1]	'C' = CodeLoc Not Entered 'E' = External Sensor 'L' = Cell Live View 'M' = Motion Sensor 'S' = Cell Status 'T' = Time Lapse
41	Sequence	int8u[2]
43	EventNumber	int32u
47	DateTimeOriginal	undef[7]
54	DayOfWeek	int8u	1 = Sunday 2 = Monday 3 = Tuesday 4 = Wednesday  5 = Thursday 6 = Friday 7 = Saturday
55	MoonPhase	int8u	0 = New 1 = New Crescent 2 = First Quarter 3 = Waxing Gibbous  4 = Full 5 = Waning Gibbous 6 = Last Quarter7 = Old Crescent
56	AmbientTemperatureFahrenheit	int16s
58	AmbientTemperature	int16s
60	Contrast	int16u
62	Brightness	int16u
64	Sharpness	int16u
66	Saturation	int16u
68	Flash	int8u	0 = Off1 = On
69	AmbientLight	int32u
73	MotionSensitivity	int16u
75	BatteryVoltage	int16u
77	BatteryVoltageAvg	int16u
79	BatteryType	int16u	1 = NiMH 2 = Lithium 3 = External 4 = SC10 Solar
81	UserLabel	string[51]
132	SerialNumber	string[15]
147	DirectoryNumber	int16u
149	FileNumber	int16u

Ignore "Writeable" for our purposes, but the decoding of TriggerMode, DayOfWeek, MoonPhase and BatteryType should be incorporated.

Note that the current implementation of DayOfWeek isn't right as the values start at index 0, but we need it to start at 1. There's an overload or optional parameter that allows this IIRC.

[Copilot]

@copilot, Exiftool has some docs on this makertnote at https://exiftool.org/TagNames/Reconyx.html

Copying here:
...

Implemented ExifTool-compatible decoding in commit 01fa744. Updated all four fields based on the ExifTool documentation:

TriggerMode (EventType): Now decodes character values to meaningful descriptions:

• 'C' → "CodeLoc Not Entered", 'E' → "External Sensor", 'L' → "Cell Live View", 'M' → "Motion Sensor", 'S' → "Cell Status", 'T' → "Time Lapse"

DayOfWeek: Fixed to use 1-based indexing with GetIndexedDescription(TagDateDayOfWeek, 1, ...) so 1=Sunday, 2=Monday, etc.

MoonPhase: Updated phase names to match ExifTool specification:

• Index 1: "New Crescent" (was "Waxing Crescent")
• Index 7: "Old Crescent" (was "Waning Crescent")

BatteryType: Now decodes with 1-based indexing:

• 1 → "NiMH", 2 → "Lithium", 3 → "External", 4 → "SC10 Solar"

All changes tested and verified to work correctly with the documented ExifTool values.

[drewnoakes]

@copilot please address the review feedback above.

[Copilot]

@copilot please address the review feedback above.

Addressed all review feedback in commit 12f1f4a:

1. Firmware revision methods: Now report numeric values instead of treating bytes as characters
2. UIB naming: Updated constants from "TagUIB*" to "TagUib*" per .NET naming guidelines
3. Comment indentation: Fixed inconsistent spacing in TagAggregateMakernoteVersion
4. DateTime validation: Removed from ExifTiffHandler, added TryGetDateTime() method to descriptor instead
5. PublicAPI updates: Updated all three target framework files with the new constant and method names

The implementation now follows proper .NET conventions and separates concerns between raw value storage and computed value access.

[drewnoakes]

Looks decent but requires manual validation.