Skip to content

Missing Complex Vowels #8

@roe-ese

Description

@roe-ese

#Firstly, I'd like to thank you for putting to together and sharing this fantastic tool.

Hangul.assemble(['ㅅ','ㅓ','ㅣ']); // Results in '서 ㅣ' and not '세'.

This issue concerns the following for 'Hangul.assemble()':
'ㅏ,ㅣ'
'ㅓ,ㅣ'
'ㅗ,ㅏ,ㅣ'
'ㅘ,ㅣ'
'ㅜ,ㅓ,ㅣ'
'ㅝ,ㅣ'

Added these to the 'COMPLEX_VOWELS' array might resolve this issue, however the triplets, e.g. 'ㅜ,ㅓ,ㅣ' might require this array to be completely reformatted. It seems like 'COMPLEX_VOWELS' are only diphthongs and do not accommodate triphthongs.

hangul.js, Line 64
COMPLEX_VOWELS = [
['ㅏ','ㅣ','ㅐ'],
['ㅓ','ㅣ','ㅔ'],
['ㅗ','ㅏ','ㅘ'],
['ㅗ','ㅐ','ㅙ'],
['ㅘ','ㅣ','ㅙ'],
['ㅗ','ㅣ','ㅚ'],
['ㅜ','ㅓ','ㅝ'],
['ㅜ','ㅔ','ㅞ'],
['ㅝ','ㅣ','ㅞ'],
['ㅜ','ㅣ','ㅟ'],
['ㅡ','ㅣ','ㅢ']
],

I haven't added ['ㅗ','ㅏ','ㅣ','ㅙ'], [''ㅗ,'ㅓ','ㅣ','ㅞ']

Kindly,
James Ro
#(노경진)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions