Reset the request when failure happens when send an HttpClientRequest stream #5642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@vietj is there anything blocking on this PR ? Do you think it's achievable ? |
Member
Author
|
I'd like the CI to confirm it passes |
… stream. Motivation: HttpClientRequest#send(ReadStream<Buffer>) pipes the stream to the request with the default behavior that is to end the stream. Instead it should signal the error and reset the stream.
vietj
force-pushed
the
http-client-request-send-stream-failure
branch
from
cbb5087 to
02eaeeb
Compare
Contributor
|
Hi @vietj, Any news on that front ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
HttpClientRequest#send(ReadStream<Buffer>)pipes the stream to the request with the default behavior that is to end the stream.Instead it should signal the error and reset the stream.