Report AsyncFile handler failures to context - #6300
Draft
Boulea7 wants to merge 1 commit into
Draft
Conversation
Member
|
can you make two contributions instead of one that makes 2 changes ? |
Author
|
Thanks, I'll split these into two separate contributions. |
Boulea7
marked this pull request as draft
August 11, 2026 08:41
Boulea7
force-pushed
the
fix-5343-async-file-handler-failures
branch
from
August 11, 2026 08:45
0fac57e to
eee248e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Fixes #5343.
Exceptions thrown by AsyncFile data or end handlers should be reported to the owning Context, matching existing Vert.x handler semantics and the maintainer guidance in the issue.
This change installs a context exception handler on the AsyncFile inbound buffer and adds regression coverage for both handler types.
Testing:
mvn -pl vertx-core -Dtest=FileSystemTest#testAsyncFileHandlerFailuresAreReportedToContext test -B— 1 passedmvn -pl vertx-core -Dtest=FileSystemTest,InboundBufferTest test -B— 141 passedmvn -pl vertx-core -DskipTests verify -Pcheckstyle -B— passed; Spotless reported 0 files needing changesgit diff --check origin/master...HEAD— passedBefore this split, an earlier broad local run was not fully green. It encountered two unrelated environment-sensitive failures outside the modified paths:
NameResolverTest#testRotationalServerSelection: expected127.0.0.4but observed127.0.0.3.Http1xTest#requestAbsNoPort: connection timeout towww.google.com:80.These are not counted as passing tests. All 142 relevant test executions listed above passed on the current rebased commit.
Conformance:
AI assistance: OpenAI Codex assisted with implementation and testing.