error: Record transaction.name when available#1177
Merged
stuartnelson3 merged 5 commits intoelastic:masterfrom Dec 22, 2021
marclop:f/add-transaction.name-to-error
Merged
error: Record transaction.name when available#1177stuartnelson3 merged 5 commits intoelastic:masterfrom marclop:f/add-transaction.name-to-error
transaction.name when available#1177stuartnelson3 merged 5 commits intoelastic:masterfrom
marclop:f/add-transaction.name-to-error
Conversation
Adds a new `transaction.name` field which is recorded when a transaction is set for the error. Signed-off-by: Marc Lopez Rubio <marc5.12@outlook.com>
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
Signed-off-by: Marc Lopez Rubio <marc5.12@outlook.com>
Signed-off-by: Marc Lopez Rubio <marc5.12@outlook.com>
stuartnelson3
approved these changes
Dec 22, 2021
Member
|
Verified using go.elastic.co/apm/v2 v2.0.0-20220209134054-640a916049c9 (current main). package main
import (
"context"
"errors"
"go.elastic.co/apm/v2"
)
func main() {
tracer := apm.DefaultTracer()
defer tracer.Flush(nil)
tracer.NewError(errors.New("err1")).Send()
tx := tracer.StartTransaction("name", "type")
ctx := apm.ContextWithTransaction(context.Background(), tx)
apm.CaptureError(ctx, errors.New("err2")).Send()
tx.Name = "new_name"
tx.End()
}
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a new
transaction.namefield which is recorded when a transactionis set for the error.
Related issues
Closes #1154