Skip to content

fix: panic on gocql#1180

Merged
marclop merged 4 commits intoelastic:masterfrom
skynet2:gocqlpanic
Dec 28, 2021
Merged

fix: panic on gocql#1180
marclop merged 4 commits intoelastic:masterfrom
skynet2:gocqlpanic

Conversation

@skynet2
Copy link
Contributor

@skynet2 skynet2 commented Dec 21, 2021

Currently there is a possibility to receive a panic, while using apmgocql module, this situation can occur while passing context which does not have apm transaction attached

@ghost
Copy link

ghost commented Dec 21, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-12-23T02:06:37.188+0000

  • Duration: 31 min 7 sec

  • Commit: cdbf39e

Test stats 🧪

Test Results
Failed 0
Passed 11977
Skipped 279
Total 12256

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark test.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@marclop
Copy link
Contributor

marclop commented Dec 22, 2021

@skynet2 thanks for submitting this contribution, the change looks sensible to me. Would you mind signing the contributor agreement? Here's a link to it: https://www.elastic.co/contributor-agreement.

@skynet2
Copy link
Contributor Author

skynet2 commented Dec 22, 2021

Hi @marclop ,
Done, thanks.

Copy link
Contributor

@marclop marclop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for the contribution.

@marclop marclop enabled auto-merge (squash) December 23, 2021 02:42
@marclop
Copy link
Contributor

marclop commented Dec 28, 2021

run elasticsearch-ci/docs

@marclop marclop merged commit 45ca397 into elastic:master Dec 28, 2021
@simitt simitt added this to the 2.0 milestone Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment