Merged
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
marclop
approved these changes
Jan 14, 2022
CHANGELOG.asciidoc
Outdated
| - Remove stacktrace.ContextSetter {pull}1187[#(1187)] | ||
| - Drop support for versions of Go prior to 1.15.0 {pull}1190[#(1190)] | ||
| - Replace apm.DefaultTracer with an initialization function {pull}1189[#(1189)] | ||
| - Remove transport.Default, construct a new Transport in each new tracer {pull}[#()] |
Contributor
There was a problem hiding this comment.
Thank you for adding the missing notes to the change log, I've been meaning to do so, but hadn't gotten to it.
axw
commented
Jan 14, 2022
Contributor
|
I verified that package main
import (
"go.elastic.co/apm/v2/transport"
)
func main() {
transport.Default
}$ go run a/main.go
# command-line-arguments
a/main.go:25:2: undefined: transport.Default |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
transport.Default, and construct a new transport for each new tracer. This will enable us to pass the tracer's associated service name and version into its transport, for appending to the User-Agent header.Closes #1194