Skip to content

Added span request name option to echo tracer#1268

Merged
axw merged 2 commits intoelastic:mainfrom
aneshas:echo-request-name
Jul 21, 2022
Merged

Added span request name option to echo tracer#1268
axw merged 2 commits intoelastic:mainfrom
aneshas:echo-request-name

Conversation

@aneshas
Copy link
Contributor

@aneshas aneshas commented Jul 19, 2022

Adding a span name option to echo apm middleware such as the one apmhttp has

@cla-checker-service
Copy link

cla-checker-service bot commented Jul 19, 2022

💚 CLA has been signed

@ghost
Copy link

ghost commented Jul 19, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-20T09:02:50.164+0000

  • Duration: 61 min 37 sec

Test stats 🧪

Test Results
Failed 0
Passed 7372
Skipped 174
Total 7546

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark test.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Member

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aneshas! Looks good, just one small nitpick about a doc comment.

Co-authored-by: Andrew Wilkins <axwalk@gmail.com>
@ghost
Copy link

ghost commented Jul 20, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (59/59) 💚
Files 99.346% (152/153) 👍
Classes 96.254% (334/347) 👍
Methods 90.255% (954/1057) 👎 -0.018
Lines 82.203% (11044/13435) 👎 -0.073
Conditionals 100.0% (0/0) 💚
@axw
Copy link
Member

axw commented Jul 21, 2022

Thanks :)

@axw axw merged commit 5015c92 into elastic:main Jul 21, 2022
@aneshas aneshas deleted the echo-request-name branch July 21, 2022 07:50
@aneshas
Copy link
Contributor Author

aneshas commented Jul 28, 2022

@axw might be a stupid question, but how does this actually get released (when) as a new version ?

@axw
Copy link
Member

axw commented Jul 29, 2022

@aneshas not a stupid question! We generally create new releases around the time of Elastic Stack minor releases (next one being 8.4.0). That's expected within weeks, so if you would like to update sooner, I would suggest using the unreleased commit (update modules to @latest) in your go.mod.

@aneshas
Copy link
Contributor Author

aneshas commented Aug 5, 2022

Ah tnx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 participants