fix: ensure a minimum retry interval of 5 seconds in fetching central configuration#1337
Merged
kruskall merged 3 commits intoelastic:mainfrom Nov 28, 2022
Merged
Conversation
… configuration Update config retrieval logic to ignore any max age header below 5 seconds and replacing it with 5s to ensure a minimum retry interval.
axw
reviewed
Oct 24, 2022
🌐 Coverage report
|
axw
approved these changes
Nov 22, 2022
Member
Author
|
/test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update config retrieval logic to ignore any max age header below 5 seconds and replacing it with 5s to ensure a minimum retry interval.
Closes #1322
See elastic/apm#690
See #1322