OpenTelemetry metrics exporter#1407
Merged
dmathieu merged 22 commits intoelastic:mainfrom Apr 5, 2023
dmathieu:apmotel
Merged
Conversation
Member
Author
|
Re: CI test failures on Go 1.15, 1.16 and 1.17. Otel follows the Golang release policy:
Which means it only support 1.19 and 1.20, and has therefore started using generics, making it impossible to use this version with any Go < 1.18. |
dubonzi
reviewed
Apr 2, 2023
axw
reviewed
Apr 3, 2023
Member
axw
left a comment
There was a problem hiding this comment.
Very nice! Just a couple of comments.
Signed-off-by: dmathieu <damien.mathieu@elastic.co>
Signed-off-by: dmathieu <damien.mathieu@elastic.co>
Signed-off-by: dmathieu <damien.mathieu@elastic.co>
Signed-off-by: dmathieu <damien.mathieu@elastic.co>
Signed-off-by: dmathieu <damien.mathieu@elastic.co>
Signed-off-by: dmathieu <damien.mathieu@elastic.co>
Signed-off-by: dmathieu <damien.mathieu@elastic.co>
Signed-off-by: dmathieu <damien.mathieu@elastic.co>
Signed-off-by: dmathieu <damien.mathieu@elastic.co>
Signed-off-by: dmathieu <damien.mathieu@elastic.co>
Signed-off-by: dmathieu <damien.mathieu@elastic.co>
Signed-off-by: dmathieu <damien.mathieu@elastic.co>
Signed-off-by: dmathieu <damien.mathieu@elastic.co>
Signed-off-by: dmathieu <damien.mathieu@elastic.co>
Signed-off-by: dmathieu <damien.mathieu@elastic.co>
Signed-off-by: dmathieu <damien.mathieu@elastic.co>
12 tasks
marclop
reviewed
Apr 4, 2023
axw
reviewed
Apr 4, 2023
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is setting up an OpenTelemetry metrics exporter, based on the specification in elastic/apm#742.