apmotel: follow APM OTel spec and prefer delta temporality#1437
apmotel: follow APM OTel spec and prefer delta temporality#1437carsonip merged 8 commits intoelastic:mainfrom
Conversation
d75abf1 to
3ad3c80
Compare
axw
left a comment
There was a problem hiding this comment.
Thanks! This brings us closer to the spec https://github.com/elastic/apm/blob/main/specs/agents/metrics-otel.md#aggregation-temporality
There's also this:
For all instrument types with delta temporality, agents MUST filter out zero values before exporting. E.g. if a counter does not change since the last export, it must not be exported.
If you have time, could you take a stab at that too? Otherwise could you please open an issue?
Taken a stab at it, see if it makes sense to you. |
axw
left a comment
There was a problem hiding this comment.
LGTM with the panic removed. Thanks!
axw
left a comment
There was a problem hiding this comment.
LGTM with the panic removed. Thanks!
Co-authored-by: Andrew Wilkins <axwalk@gmail.com>
…t-go into otel-delta-temporality
Make apmotel follow apm otel spec: https://github.com/elastic/apm/blob/main/specs/agents/metrics-otel.md#aggregation-temporality
Closes #1436