Handle context flags when creating remote transactions and spans#1441
Merged
dmathieu merged 1 commit intoelastic:mainfrom May 17, 2023
dmathieu:propagate-sample
Merged
Handle context flags when creating remote transactions and spans#1441dmathieu merged 1 commit intoelastic:mainfrom dmathieu:propagate-sample
dmathieu merged 1 commit intoelastic:mainfrom
dmathieu:propagate-sample
Conversation
carsonip
approved these changes
May 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to properly handle traceflags in the context when creating transactions and spans that come from distributed services, or everything is considered as unsampled (and we don't get any data if there is a remote context).