Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
LikeTheSalad
previously approved these changes
Jun 19, 2025
Contributor
LikeTheSalad
left a comment
LikeTheSalad
left a comment
There was a problem hiding this comment.
Added a comment just to make sure if we need to change the otel repo by a fork.
reverted opentelemetry-swift version
LikeTheSalad
approved these changes
Jun 23, 2025
|
@bryce-b What I noticed if that with this change its fine to add a custom path, but the path is not reflected in the OpenTelemetryHelper.swift file. The getURL function does not take the 'collectorPath' property from the config into account at all. Or is there another way to config a collector path for the OT part? |
Contributor
Author
|
@stefantheissen Thanks for pointing this out, I'll create an issue and get it fixed asap. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also bumps otel-swift to latest version.reverted otel-swift version due to changes in the SDK breaking our agent.