Make continuous profiling the default, rename inferred spans config option#1084
Merged
felixbarny merged 4 commits intomasterfrom Mar 16, 2020
Merged
Make continuous profiling the default, rename inferred spans config option#1084felixbarny merged 4 commits intomasterfrom
felixbarny merged 4 commits intomasterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1084 +/- ##
============================================
- Coverage 60.74% 60.54% -0.20%
Complexity 87 87
============================================
Files 320 320
Lines 14446 14357 -89
Branches 1988 1976 -12
============================================
- Hits 8775 8693 -82
+ Misses 5091 5082 -9
- Partials 580 582 +2
Continue to review full report at Codecov.
|
eyalkoren
approved these changes
Mar 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Profiling should run continuously in the background, rather than run profiling sessions which run for 10 seconds each minute for the following reasons:
The
profiling_intervalandprofiling_durationoptions are removed and are hard-coded to5s(down from10s). This has the following advantages:Also renames configuration options for consistency (everything is prefixed with
profiling_inferred_spans_)The default for the
profiling_inferred_spans_sampling_intervalis increased from20msto50ms, which matches the default value for the wall clock mode of async-profiler.As the inferred spans feature is marked experimental, there's no backwards compatibility with the previous configuration options. When migrating to the new options, it's best to just set both, the old and the new ones.