Not overriding status code for non-core-Servlet Exceptions#1103
Merged
eyalkoren merged 3 commits intoelastic:masterfrom Mar 31, 2020
Merged
Not overriding status code for non-core-Servlet Exceptions#1103eyalkoren merged 3 commits intoelastic:masterfrom
eyalkoren merged 3 commits intoelastic:masterfrom
Conversation
felixbarny
approved these changes
Mar 30, 2020
Codecov Report
@@ Coverage Diff @@
## master #1103 +/- ##
=========================================
Coverage 60.10% 60.10%
Complexity 87 87
=========================================
Files 327 327
Lines 14828 14828
Branches 2087 2087
=========================================
Hits 8912 8912
Misses 5318 5318
Partials 598 598 Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the bug of setting a 500 status code on responses from error pages that actually return 200 but with an Exception set as a Request attribute
Checklist
Related issues
Fixes #1036
Use cases
Using Exception handlers that do not return an error status code