Skip to content

Not overriding status code for non-core-Servlet Exceptions#1103

Merged
eyalkoren merged 3 commits intoelastic:masterfrom
eyalkoren:fix-status-code
Mar 31, 2020
Merged

Not overriding status code for non-core-Servlet Exceptions#1103
eyalkoren merged 3 commits intoelastic:masterfrom
eyalkoren:fix-status-code

Conversation

@eyalkoren
Copy link
Contributor

@eyalkoren eyalkoren commented Mar 30, 2020

What does this PR do?

Fixes the bug of setting a 500 status code on responses from error pages that actually return 200 but with an Exception set as a Request attribute

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Related issues

Fixes #1036

Use cases

Using Exception handlers that do not return an error status code

@eyalkoren eyalkoren self-assigned this Mar 30, 2020
@eyalkoren eyalkoren requested a review from felixbarny March 30, 2020 11:55
@codecov-io
Copy link

codecov-io commented Mar 30, 2020

Codecov Report

Merging #1103 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1103   +/-   ##
=========================================
  Coverage     60.10%   60.10%           
  Complexity       87       87           
=========================================
  Files           327      327           
  Lines         14828    14828           
  Branches       2087     2087           
=========================================
  Hits           8912     8912           
  Misses         5318     5318           
  Partials        598      598           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97a3d76...d3248f5. Read the comment docs.

@eyalkoren eyalkoren merged commit 4f7a6e2 into elastic:master Mar 31, 2020
@eyalkoren eyalkoren deleted the fix-status-code branch March 31, 2020 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants