Fix span sub-type missing in breakdown metrics#1113
Merged
SylvainJuge merged 3 commits intoelastic:masterfrom Apr 1, 2020
Merged
Fix span sub-type missing in breakdown metrics#1113SylvainJuge merged 3 commits intoelastic:masterfrom
SylvainJuge merged 3 commits intoelastic:masterfrom
Conversation
as a bonus span subtype wasn't being reset properly
felixbarny
approved these changes
Mar 31, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes broken breakdown metrics reporting.
For example, when there was multiple database vendors used, only one of them was included in breakdown metrics, thus with an app with
mysqlandredis, at most one of them was being reported, but not both.What does this PR do?
Checklist
I have updated supported-technologies.asciidocAdded an API method or config option? Document in which version this will be introducedAdded an instrumentation plugin? How did you make sure that old, non-supported versions are not instrumented by accident?Related issues
Screenshot
With an application that has two database spans sub-types:
h2andotherBefore
After