Fix parent/child issues with inferred spans#1117
Merged
felixbarny merged 21 commits intoelastic:masterfrom May 12, 2020
Merged
Conversation
Inferred spans can track a list of child or successor ids With transitive reduction, the UI can then make regular spans a child of inferred spans
This capacity seems to be the most effective in the benchmarks But it's going to depend a lot on the application 16 still seems like a good default. It grows much quicker if the actual capacity is high but still does not seem wasteful for lower capacity needs. It's also the default for lists in the JDK
- Add changelog - Adjust known issues documentation
eyalkoren
approved these changes
Apr 26, 2020
...agent-plugins/apm-profiling-plugin/src/main/java/co/elastic/apm/agent/profiler/CallTree.java
Outdated
Show resolved
Hide resolved
...agent-plugins/apm-profiling-plugin/src/main/java/co/elastic/apm/agent/profiler/CallTree.java
Show resolved
Hide resolved
...t-plugins/apm-profiling-plugin/src/test/java/co/elastic/apm/agent/profiler/CallTreeTest.java
Outdated
Show resolved
Hide resolved
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
eyalkoren
reviewed
May 5, 2020
...t-plugins/apm-profiling-plugin/src/test/java/co/elastic/apm/agent/profiler/CallTreeTest.java
Show resolved
Hide resolved
| {"1", 13}, | ||
| {" a", 11}, | ||
| {" b", 2}, | ||
| {" 2", 6}, |
Contributor
There was a problem hiding this comment.
How come 2 is not a child of a?
Member
Author
There was a problem hiding this comment.
Wow, good catch! From now on, I call you the eagle eye. Or maybe Eyeal 🤔
Submitting fix shortly that searches for common ancestors, instead of always adding the child_ids on the top of the stack
felixbarny
commented
May 6, 2020
...t-plugins/apm-profiling-plugin/src/test/java/co/elastic/apm/agent/profiler/CallTreeTest.java
Outdated
Show resolved
Hide resolved
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
- Adds internal profiling_inferred_spans_backup_diagnostic_files option - Adds SamplingProfilerReplay to diagnose issues when creating inferred spans
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inferred spans can track a list of child or successor ids
With transitive reduction, the UI can then make regular spans a child of inferred spans
What does this PR do?
closes #1112
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have updated supported-technologies.asciidoc[ ] Added an API method or config option? Document in which version this will be introduced[ ] Added an instrumentation plugin? How did you make sure that old, non-supported versions are not instrumented by accident?