Fix OpenTracing error tag handling#1159
Merged
felixbarny merged 2 commits intoelastic:masterfrom Apr 28, 2020
Merged
Conversation
|
💚 CLA has been signed |
felixbarny
approved these changes
Apr 28, 2020
Member
|
Thx for the fix, after signing the CLA, we're good to go 👍 |
Contributor
Author
|
Cool - I've signed it, let me know if it's not right somehow |
Member
|
Looks good. Could you update the changelog? |
Member
|
Thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates the OpenTracing bridge to propagate
span.setTag("error", true)to the transaction result correctly.At present, the boolean comparison is inverted so that
span.setTag("error", false)will propagate to an error result (buttruewill not).Checklist
- [ ] I have made corresponding changes to the documentation- [ ] I have updated supported-technologies.asciidoc- [ ] Added an API method or config option? Document in which version this will be introduced- [ ] Added an instrumentation plugin? How did you make sure that old, non-supported versions are not instrumented by accident?