Dynamic logger ecs reconfig#1261
Conversation
Tail that log and send to APM Server to the not yet existing /intake/v2/logs endpoint
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
felixbarny
left a comment
There was a problem hiding this comment.
I know this is not ready yet but I was too curious about this PR :)
...og-shader-plugin/src/main/java/co/elastic/apm/agent/log/shader/AbstractLogShadingHelper.java
Outdated
Show resolved
Hide resolved
...og-shader-plugin/src/main/java/co/elastic/apm/agent/log/shader/AbstractLogShadingHelper.java
Outdated
Show resolved
Hide resolved
...in/src/main/java/co/elastic/apm/agent/log/shader/log4j2/Log4j2LogShadingInstrumentation.java
Outdated
Show resolved
Hide resolved
...ugin/src/main/java/co/elastic/apm/agent/log/shader/log4j2/helper/Log4j2LogShadingHelper.java
Outdated
Show resolved
Hide resolved
...in/src/main/java/co/elastic/apm/agent/log/shader/logback/helper/LogbackLogShadingHelper.java
Outdated
Show resolved
Hide resolved
|
OK, at last ready for a review. Supported technologies page is updated with supported versions (and the addition of Logback). Legacy tests use the earliest-supported version and there is a test for a recent version. For log4j1, the earliest supported version is the latest version, as it is the first compiled with Java 1.4. Also worth noticing: the ECS |
apm-agent-core/src/main/java/co/elastic/apm/agent/logging/LoggingConfiguration.java
Outdated
Show resolved
Hide resolved
...plugin/apm-log-shader-plugin-common/src/main/java/co/elastic/apm/agent/log/shader/Utils.java
Outdated
Show resolved
Hide resolved
...er-plugin-common/src/main/java/co/elastic/apm/agent/log/shader/AbstractLogShadingHelper.java
Show resolved
Hide resolved
...er-plugin-common/src/main/java/co/elastic/apm/agent/log/shader/AbstractLogShadingHelper.java
Outdated
Show resolved
Hide resolved
...log4j1-plugin/src/main/java/co/elastic/apm/agent/log4j1/Log4j1LogShadingInstrumentation.java
Show resolved
Hide resolved
...-logback-plugin-impl/src/main/java/co/elastic/apm/agent/logback/LogbackLogShadingHelper.java
Outdated
Show resolved
Hide resolved
...ugin/apm-log4j1-plugin/src/main/java/co/elastic/apm/agent/log4j1/Log4j1LogShadingHelper.java
Show resolved
Hide resolved
...er-plugin-common/src/main/java/co/elastic/apm/agent/log/shader/AbstractLogShadingHelper.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Felix Barnsteiner <felixbarny@users.noreply.github.com>
…into dynamic-logger-ecs-reconfig
felixbarny
left a comment
There was a problem hiding this comment.
We might have to refine how the service.name is computed but let's not block this PR on that. It's an experimental feature anyway.
What does this PR do?
Checklist