Skip to content

Delay init by default in Tomcat and JBoss, only once#1262

Merged
eyalkoren merged 6 commits intoelastic:masterfrom
eyalkoren:delay-init-once-only
Jul 7, 2020
Merged

Delay init by default in Tomcat and JBoss, only once#1262
eyalkoren merged 6 commits intoelastic:masterfrom
eyalkoren:delay-init-once-only

Conversation

@eyalkoren
Copy link
Contributor

@eyalkoren eyalkoren commented Jun 30, 2020

What does this PR do?

Fixes #1246 (main issue is the infamous JUL deadlock, in addition - a bug of multiple delays).

Checklist

  • This is an enhancement of existing features, or a new feature in existing plugins
    • I have updated CHANGELOG.asciidoc
    • I have added tests that prove my fix is effective or that my feature works
    • Added an API method or config option? Document in which version this will be introduced
    • I have made corresponding changes to the documentation
  • This is a bugfix
    • I have updated CHANGELOG.asciidoc
    • [ ] I have added tests that would fail without this fix This one is tested manually
  • This is a new plugin
    • I have updated CHANGELOG.asciidoc
    • My code follows the style guidelines of this project
    • I have made corresponding changes to the documentation
    • I have added tests that prove my fix is effective or that my feature works
    • New and existing unit tests pass locally with my changes
    • I have updated CHANGELOG.asciidoc
    • I have updated supported-technologies.asciidoc
    • Added an API method or config option? Document in which version this will be introduced
    • Added an instrumentation plugin? Describe how you made sure that old, non-supported versions are not instrumented by accident.
  • This is something else
@ghost
Copy link

ghost commented Jun 30, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Started by user eyalkoren, Replayed #7]

  • Start Time: 2020-07-07T04:21:07.503+0000

  • Duration: 40 min 32 sec

Test stats 🧪

Test Results
Failed 0
Passed 562
Skipped 11
Total 573

@eyalkoren eyalkoren changed the title Delay init only once Jul 1, 2020
@eyalkoren eyalkoren changed the title Delay init by default and only once Jul 1, 2020
@eyalkoren eyalkoren requested a review from felixbarny July 2, 2020 13:25
@eyalkoren eyalkoren merged commit 9d9820b into elastic:master Jul 7, 2020
@eyalkoren eyalkoren deleted the delay-init-once-only branch July 7, 2020 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants