Skip to content

Enable instrumentation of Java 1.4 bytecode#1317

Merged
eyalkoren merged 2 commits intoelastic:masterfrom
eyalkoren:enabling-instrumentation-of-java-1_4
Jul 29, 2020
Merged

Enable instrumentation of Java 1.4 bytecode#1317
eyalkoren merged 2 commits intoelastic:masterfrom
eyalkoren:enabling-instrumentation-of-java-1_4

Conversation

@eyalkoren
Copy link
Contributor

@eyalkoren eyalkoren commented Jul 29, 2020

What does this PR do?

Enables instrumentation of classes compiled with Java 1.4.

Checklist

  • This is an enhancement of existing features, or a new feature in existing plugins
    • I have updated CHANGELOG.asciidoc
    • I have added tests that prove my fix is effective or that my feature works
    • I have made corresponding changes to the documentation
  • This is a bugfix
  • This is a new plugin
    • I have updated CHANGELOG.asciidoc
    • My code follows the style guidelines of this project
    • I have made corresponding changes to the documentation
    • I have added tests that prove my fix is effective or that my feature works
    • New and existing unit tests pass locally with my changes
    • I have updated CHANGELOG.asciidoc
    • I have updated supported-technologies.asciidoc
    • Added an API method or config option? Document in which version this will be introduced
    • Added an instrumentation plugin? Describe how you made sure that old, non-supported versions are not instrumented by accident.
  • This is something else
@eyalkoren eyalkoren requested a review from felixbarny July 29, 2020 13:10
@ghost
Copy link

ghost commented Jul 29, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #1317 opened]

  • Start Time: 2020-07-29T13:10:18.382+0000

  • Duration: 49 min 11 sec

Test stats 🧪

Test Results
Failed 0
Passed 1426
Skipped 11
Total 1437

@eyalkoren eyalkoren merged commit 7baac85 into elastic:master Jul 29, 2020
@eyalkoren eyalkoren deleted the enabling-instrumentation-of-java-1_4 branch July 29, 2020 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants