Skip to content

Support early access java version#1325

Merged
eyalkoren merged 2 commits intoelastic:masterfrom
eyalkoren:early-access-java-version
Aug 4, 2020
Merged

Support early access java version#1325
eyalkoren merged 2 commits intoelastic:masterfrom
eyalkoren:early-access-java-version

Conversation

@eyalkoren
Copy link
Contributor

@eyalkoren eyalkoren commented Aug 4, 2020

What does this PR do?

Supports dashes in Java major version, eg 15-ea+34-1554.
Before this fix, the agent would through a NumberFormatException

Checklist

  • This is an enhancement of existing features, or a new feature in existing plugins
    • I have updated CHANGELOG.asciidoc
    • I have added tests that prove my fix is effective or that my feature works
    • Added an API method or config option? Document in which version this will be introduced
    • I have made corresponding changes to the documentation
  • This is a bugfix
  • This is a new plugin
    • I have updated CHANGELOG.asciidoc
    • My code follows the style guidelines of this project
    • I have made corresponding changes to the documentation
    • I have added tests that prove my fix is effective or that my feature works
    • New and existing unit tests pass locally with my changes
    • I have updated supported-technologies.asciidoc
    • Added an API method or config option? Document in which version this will be introduced
    • Added an instrumentation plugin? Describe how you made sure that old, non-supported versions are not instrumented by accident.
  • This is something else
Copy link
Member

@felixbarny felixbarny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

contains unrelated changes, other than that LGTM

@ghost
Copy link

ghost commented Aug 4, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #1325 updated]

  • Start Time: 2020-08-04T13:58:55.494+0000

  • Duration: 45 min 49 sec

Test stats 🧪

Test Results
Failed 0
Passed 1435
Skipped 11
Total 1446

Steps errors

Expand to view the steps failures

  • Name: Download Codecov
    • Description: #!/bin/bash set -x curl -sSLo codecov.sh https://codecov.io/bash

    • Duration: 2 min 22 sec

    • Start Time: 2020-08-04T14:41:13.993+0000

    • log

@eyalkoren eyalkoren force-pushed the early-access-java-version branch from 2b7b95a to 19ffe65 Compare August 4, 2020 13:58
@eyalkoren eyalkoren merged commit 5e994ff into elastic:master Aug 4, 2020
@eyalkoren eyalkoren deleted the early-access-java-version branch August 4, 2020 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants