Replace System Rules with System Lambda#1434
Merged
eyalkoren merged 1 commit intoelastic:masterfrom Oct 13, 2020
stefanbirkner:system-lambda
Merged
Replace System Rules with System Lambda#1434eyalkoren merged 1 commit intoelastic:masterfrom stefanbirkner:system-lambda
eyalkoren merged 1 commit intoelastic:masterfrom
stefanbirkner:system-lambda
Conversation
|
💚 CLA has been signed |
System Lambda is independent of the test framework while System Rules is build for JUnit 4. We are using JUnit Jupiter and therefore System Lambda is the better choice. In addition System Lambda is more precise. It allows to set environment variables for a single statement only. This already improves the readability of the test because you can now immediately see which environment variables are set when SystemInfo#findContainerDetails is executed.
Contributor
|
@stefanbirkner Thanks!! |
Codecov Report
@@ Coverage Diff @@
## master #1434 +/- ##
=========================================
Coverage ? 59.82%
Complexity ? 91
=========================================
Files ? 387
Lines ? 17460
Branches ? 2396
=========================================
Hits ? 10445
Misses ? 6299
Partials ? 716 Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
System Lambda is independent of the test framework while System Rules is
build for JUnit 4. We are using JUnit Jupiter and therefore System
Lambda is the better choice.
In addition System Lambda is more precise. It allows to set environment
variables for a single statement only. This already improves the
readability of the test because you can now immediately see which
environment variables are set when SystemInfo#findContainerDetails is
executed.
Checklist