Skip to content

feature added setLabel methods to Span, Transaction of public api#1449

Merged
eyalkoren merged 5 commits intoelastic:masterfrom
videnkz:feature-add-set-label-to-public-api
Nov 9, 2020
Merged

feature added setLabel methods to Span, Transaction of public api#1449
eyalkoren merged 5 commits intoelastic:masterfrom
videnkz:feature-add-set-label-to-public-api

Conversation

@videnkz
Copy link
Contributor

@videnkz videnkz commented Oct 21, 2020

closes #1446

@ghost
Copy link

ghost commented Oct 21, 2020

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Started by user eyalkoren, Replayed #7]

  • Start Time: 2020-11-09T14:06:39.357+0000

  • Duration: 44 min 13 sec

Test stats 🧪

Test Results
Failed 0
Passed 1617
Skipped 12
Total 1629

@eyalkoren eyalkoren requested a review from SylvainJuge November 9, 2020 10:55
Copy link
Member

@SylvainJuge SylvainJuge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I just have one question regarding the @since javadoc tag value.

@felixbarny
Copy link
Member

The APM getting started docs also mention addLabel so they need to be updated as well: https://www.elastic.co/guide/en/apm/get-started/current/metadata.html#labels-fields

@codecov-io
Copy link

Codecov Report

Merging #1449 (bd0ecc7) into master (f4ba580) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1449      +/-   ##
============================================
- Coverage     59.28%   59.26%   -0.03%     
- Complexity       92     2716    +2624     
============================================
  Files           392      392              
  Lines         17626    17626              
  Branches       2443     2443              
============================================
- Hits          10450    10446       -4     
- Misses         6461     6464       +3     
- Partials        715      716       +1     
Impacted Files Coverage Δ Complexity Δ
...ic/apm/agent/profiler/collections/LongHashSet.java 15.87% <0.00%> (-1.59%) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4ba580...bd0ecc7. Read the comment docs.

@eyalkoren eyalkoren merged commit e04a1d3 into elastic:master Nov 9, 2020
eyalkoren added a commit to elastic/apm-server that referenced this pull request Nov 9, 2020
The `addLabel` API is deprecated in favour of `setLabel` (see elastic/apm-agent-java#1449).
The link is valid, only it will now link to the documentation of `addLabel`, but we will backport our documentation update very soon.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants