implement fix for hp-ux version parsing#1477
Merged
eyalkoren merged 6 commits intoelastic:masterfrom Nov 9, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1477 +/- ##
============================================
+ Coverage 59.25% 64.05% +4.80%
- Complexity 92 3101 +3009
============================================
Files 392 305 -87
Lines 17604 15225 -2379
Branches 2437 2107 -330
============================================
- Hits 10431 9753 -678
+ Misses 6458 4804 -1654
+ Partials 715 668 -47
Continue to review full report at Codecov.
|
felixbarny
approved these changes
Nov 6, 2020
eyalkoren
reviewed
Nov 8, 2020
Contributor
eyalkoren
left a comment
There was a problem hiding this comment.
Nice.
We need to document the disable_bootstrap_checks flag somehow.
See suggestion to do that when aborting at startup.
In addition, I think we can at least add it to the NOTE message we have at the supported Java version section.
This section needs to be updated to include these new JVM limitations as well.
apm-agent-core/src/main/java/co/elastic/apm/agent/bci/AgentMain.java
Outdated
Show resolved
Hide resolved
…n.java add self-documenting error message Co-authored-by: eyalkoren <41850454+eyalkoren@users.noreply.github.com>
…pux-version-parsing
eyalkoren
approved these changes
Nov 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #1474
Add an extra runtime property
elastic.apm.disable_bootstrap_checksthat allows to bypass JVM version check when it's value is set totrue.Checklist
elastic.apm.disable_bootstrap_checksflag