Send error.transaction_id and error.parent_id only if there is trace_id#1537
Merged
eyalkoren merged 2 commits intoelastic:masterfrom Nov 25, 2020
Merged
Send error.transaction_id and error.parent_id only if there is trace_id#1537eyalkoren merged 2 commits intoelastic:masterfrom
eyalkoren merged 2 commits intoelastic:masterfrom
Conversation
felixbarny
approved these changes
Nov 25, 2020
Member
felixbarny
left a comment
There was a problem hiding this comment.
Do you have a suspicion why there can be a trace context with a non-empty transaction id but an empty trace id? The only things that come to my mind are race conditions or visibility issues.
Contributor
Author
No clue 🙁 . This is why I added the logs and asked the reporting user to trigger it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Context - reported in the forum.
APM Server will reject Error events that contain
parent_idand/ortransaction_idbut do not containtrace_id. This PR ensures that this restriction is enforced.In addition, it provides logs to analyze the reason for getting error captures that are not adhering this.
Checklist