Skip to content

Fix serializing all stack trace frames#1571

Merged
felixbarny merged 3 commits intoelastic:masterfrom
felixbarny:stacktrace-serialization-fix
Dec 16, 2020
Merged

Fix serializing all stack trace frames#1571
felixbarny merged 3 commits intoelastic:masterfrom
felixbarny:stacktrace-serialization-fix

Conversation

@felixbarny
Copy link
Member

@felixbarny felixbarny commented Dec 15, 2020

What does this PR do?

closes #1570

Checklist

  • This is an enhancement of existing features, or a new feature in existing plugins
    • I have updated CHANGELOG.asciidoc
    • I have added tests that prove my fix is effective or that my feature works
    • Added an API method or config option? Document in which version this will be introduced
    • I have made corresponding changes to the documentation
  • This is a bugfix
  • This is a new plugin
    • I have updated CHANGELOG.asciidoc
    • My code follows the style guidelines of this project
    • I have made corresponding changes to the documentation
    • I have added tests that prove my fix is effective or that my feature works
    • New and existing unit tests pass locally with my changes
    • I have updated supported-technologies.asciidoc
    • Added an API method or config option? Document in which version this will be introduced
    • Added an instrumentation plugin? Describe how you made sure that old, non-supported versions are not instrumented by accident.
  • This is something else
@ghost
Copy link

ghost commented Dec 15, 2020

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #1571 updated

  • Start Time: 2020-12-15T15:49:20.581+0000

  • Duration: 46 min 7 sec

Test stats 🧪

Test Results
Failed 0
Passed 1633
Skipped 12
Total 1645

@codecov-io
Copy link

Codecov Report

Merging #1571 (2e266ea) into master (81688c7) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1571      +/-   ##
============================================
+ Coverage     58.98%   58.99%   +0.01%     
  Complexity       92       92              
============================================
  Files           391      391              
  Lines         17615    17617       +2     
  Branches       2436     2437       +1     
============================================
+ Hits          10390    10394       +4     
  Misses         6508     6508              
+ Partials        717      715       -2     
Impacted Files Coverage Δ Complexity Δ
.../apm/agent/report/serialize/DslJsonSerializer.java 89.19% <100.00%> (+0.14%) 0.00 <0.00> (ø)
...ic/apm/agent/profiler/collections/LongHashSet.java 16.66% <0.00%> (-1.20%) 0.00% <0.00%> (ø%)
.../bci/bytebuddy/SoftlyReferencingTypePoolCache.java 93.75% <0.00%> (+12.50%) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81688c7...2e266ea. Read the comment docs.

@felixbarny felixbarny merged commit 3c5a14c into elastic:master Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

3 participants