properly handle exception on ServletContext.getClassLoader()#1576
Merged
SylvainJuge merged 4 commits intoelastic:masterfrom Dec 22, 2020
Merged
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
Member
Author
|
Test snapshot can be downloaded with the following link. |
Member
Author
|
Update: validated with user that the fix in this PR solves their issue. |
eyalkoren
approved these changes
Dec 20, 2020
...-plugins/apm-servlet-plugin/src/main/java/co/elastic/apm/agent/servlet/ServletApiAdvice.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The fix applied in #1464 did not covered all cases, this change makes sure that all calls to
ServletContext#getClassLoader()are properly wrapped in a try/catch to avoid potentialUnsupportedOperationException.Checklist