Skip to content

Using body buffer only if writing to it is finished#1579

Merged
eyalkoren merged 7 commits intoelastic:masterfrom
eyalkoren:body-buffer-handling
Dec 28, 2020
Merged

Using body buffer only if writing to it is finished#1579
eyalkoren merged 7 commits intoelastic:masterfrom
eyalkoren:body-buffer-handling

Conversation

@eyalkoren
Copy link
Contributor

@eyalkoren eyalkoren commented Dec 20, 2020

What does this PR do?

(hopefully) fixes #1566

Checklist

  • This is a bugfix
@codecov-io
Copy link

codecov-io commented Dec 20, 2020

Codecov Report

Merging #1579 (0447308) into master (bc6193f) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1579      +/-   ##
============================================
+ Coverage     58.66%   58.68%   +0.02%     
  Complexity       92       92              
============================================
  Files           396      396              
  Lines         17795    17797       +2     
  Branches       2468     2468              
============================================
+ Hits          10439    10445       +6     
+ Misses         6642     6639       -3     
+ Partials        714      713       -1     
Impacted Files Coverage Δ Complexity Δ
...ava/co/elastic/apm/agent/impl/context/Request.java 86.00% <100.00%> (+4.36%) 0.00 <0.00> (ø)
.../apm/agent/report/serialize/DslJsonSerializer.java 88.47% <100.00%> (ø) 0.00 <0.00> (ø)
...ic/apm/agent/profiler/collections/LongHashSet.java 18.25% <0.00%> (-1.20%) 0.00% <0.00%> (ø%)
...tic/apm/agent/report/ssl/TLSFallbackSSLSocket.java 41.30% <0.00%> (+2.17%) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc6193f...0447308. Read the comment docs.

@ghost
Copy link

ghost commented Dec 20, 2020

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #1579 updated

  • Start Time: 2020-12-27T16:18:14.409+0000

  • Duration: 45 min 15 sec

Test stats 🧪

Test Results
Failed 0
Passed 1680
Skipped 12
Total 1692

@eyalkoren eyalkoren merged commit b12e374 into elastic:master Dec 28, 2020
@eyalkoren eyalkoren deleted the body-buffer-handling branch December 28, 2020 05:13
@SylvainJuge SylvainJuge added bug Bugs and removed type: bug labels Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

3 participants