Merged
Conversation
this is especially important for counters as the counts that were accumulated between the last report and the shutdown would otherwise get lost
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
Codecov Report
@@ Coverage Diff @@
## master #1658 +/- ##
============================================
- Coverage 58.93% 58.92% -0.01%
- Complexity 92 2802 +2710
============================================
Files 404 403 -1
Lines 18441 18447 +6
Branches 2562 2564 +2
============================================
+ Hits 10868 10870 +2
- Misses 6801 6806 +5
+ Partials 772 771 -1
Continue to review full report at Codecov.
|
SylvainJuge
approved these changes
Feb 15, 2021
| Thread.currentThread().interrupt(); | ||
| } | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
😍 Let's do that by the book, or rather by-the-javadoc !
beniwohli
added a commit
to beniwohli/apm
that referenced
this pull request
May 26, 2021
Due to the somewhat lengthy default metrics collection interval of 30s, it is quite possible to lose significant amounts of metrics data if no effort is made to flush them before shutdown. See elastic/apm-agent-java#1658 for the implementation in the Java agent.
felixbarny
pushed a commit
to elastic/apm
that referenced
this pull request
Jun 16, 2021
Due to the somewhat lengthy default metrics collection interval of 30s, it is quite possible to lose significant amounts of metrics data if no effort is made to flush them before shutdown. See elastic/apm-agent-java#1658 for the implementation in the Java agent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is especially important for counters as the counts that were accumulated between the last report and the shutdown would otherwise get lost.
What does this PR do?
Checklist
Added an API method or config option? Document in which version this will be introducedI have made corresponding changes to the documentation