log readonly msg errors only in debug#1715
Merged
SylvainJuge merged 8 commits intoelastic:masterfrom Mar 30, 2021
Merged
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
felixbarny
reviewed
Mar 25, 2021
...n/apm-jms-plugin-base/src/main/java/co/elastic/apm/agent/jms/JmsMessagePropertyAccessor.java
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #1715 +/- ##
============================================
- Coverage 69.42% 61.28% -8.14%
- Complexity 2789 3620 +831
============================================
Files 291 401 +110
Lines 12413 18248 +5835
Branches 1616 2507 +891
============================================
+ Hits 8618 11184 +2566
- Misses 3214 6281 +3067
- Partials 581 783 +202
Continue to review full report at Codecov.
|
…-agent-java into silence-jms-readonly-msg
eyalkoren
approved these changes
Mar 29, 2021
3 tasks
v1v
added a commit
to v1v/apm-agent-java
that referenced
this pull request
Apr 7, 2021
…va into feature/java-stable-tag * 'feature/java-stable-tag' of github.com:v1v/apm-agent-java: (534 commits) Added Support for JBoss Logging to the log correlation plugin (elastic#1737) Removing improper RabbitMQ reference from instrumentation class (elastic#1745) Loading Advice classes lazily when required (elastic#1736) add support for ibm JVMs (elastic#1739) Adds circuit breaker to app deployment in load pipeline (elastic#1731) Bump json-schema-validator from 1.0.50 to 1.0.51 (elastic#1732) Bump java-driver-core from 4.10.0 to 4.11.0 (elastic#1733) Cassandra instrumentation (elastic#1712) Build apm-agent-attach-cli before application-server-integration-tests (elastic#1729) Fix thread pool method matchers (elastic#1717) Always use English locale when formatting doubles (elastic#1727) (elastic#1728) feat: grab locust metrics on load tests (elastic#1724) log readonly msg errors only in debug (elastic#1715) feat: use metricbeat to grab host metrics (elastic#1718) Eliminate log4j shaders dependency in slf4j (elastic#1723) Fix log correlation for log4j2 (elastic#1720) Allowing more time for the test Bump json-schema-validator from 1.0.49 to 1.0.50 (elastic#1711) Fix master build and print URL on connection error Attacher improvements (elastic#1667) ...
SylvainJuge
added a commit
that referenced
this pull request
Apr 13, 2021
* fix another way to write to JMS msg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Some JMS implementations might use read-only messages during processing, which throws
MessageNotWriteableExceptionwhen the agent tries to write context-propagation headers to it.This change allows to log those only at
debuglevel, which leaves the default logging level uncluttered with those irrelevant log messages.Checklist