Skip to content

Avoid stack frame re-computation + prevent indirect classloading#1758

Merged
SylvainJuge merged 14 commits intoelastic:masterfrom
SylvainJuge:workaround-attempt
Apr 20, 2021
Merged

Avoid stack frame re-computation + prevent indirect classloading#1758
SylvainJuge merged 14 commits intoelastic:masterfrom
SylvainJuge:workaround-attempt

Conversation

@SylvainJuge
Copy link
Member

@SylvainJuge SylvainJuge commented Apr 14, 2021

What does this PR do?

Attempt to avoid some thread locking issues that might be related to indirect classloading:

  • avoid using classloading to resolve types when using runtime instrumentation
  • avoid re-computing bytecode stack frames when not needed (depends on not-yet-released bytebuddy raphw/byte-buddy@de70e4a).

Checklist

  • This is a bugfix
@ghost
Copy link

ghost commented Apr 14, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #1758 updated

  • Start Time: 2021-04-20T13:27:15.990+0000

  • Duration: 54 min 35 sec

  • Commit: ded1d68

Test stats 🧪

Test Results
Failed 0
Passed 1990
Skipped 19
Total 2009

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 1990
Skipped 19
Total 2009

@SylvainJuge
Copy link
Member Author

Currently pending on bytebuddy 1.11.0 release (relying on a locally built snapshot).

@SylvainJuge SylvainJuge marked this pull request as ready for review April 19, 2021 11:16
@SylvainJuge SylvainJuge changed the title [draft] Runtime instrumentation issue investigation Apr 19, 2021
@SylvainJuge SylvainJuge merged commit eecbd08 into elastic:master Apr 20, 2021
@SylvainJuge SylvainJuge deleted the workaround-attempt branch April 20, 2021 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

2 participants