Support for inheriting public api annotations (#1773)#1805
Support for inheriting public api annotations (#1773)#1805eyalkoren merged 11 commits intoelastic:masterfrom
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
SylvainJuge
left a comment
There was a problem hiding this comment.
LGTM, approval of PR to enable test on CI
eyalkoren
left a comment
There was a problem hiding this comment.
Looks great, well done! 👏
A few minor suggestions.
For the config option name and description - you would need to verify that the field and method names are properly set, and you will have to run ConfigurationExporterTest so that configuration.asciidoc gets updated.
Thanks a lot, this is a very useful extension to our API!
.../apm-api-plugin/src/main/java/co/elastic/apm/agent/pluginapi/CaptureSpanInstrumentation.java
Outdated
Show resolved
Hide resolved
...i-plugin/src/main/java/co/elastic/apm/agent/pluginapi/CaptureTransactionInstrumentation.java
Outdated
Show resolved
Hide resolved
...ugins/apm-api-plugin/src/main/java/co/elastic/apm/agent/pluginapi/TracedInstrumentation.java
Outdated
Show resolved
Hide resolved
apm-agent-core/src/main/java/co/elastic/apm/agent/configuration/CoreConfiguration.java
Outdated
Show resolved
Hide resolved
apm-agent-core/src/main/java/co/elastic/apm/agent/configuration/CoreConfiguration.java
Outdated
Show resolved
Hide resolved
apm-agent-core/src/main/java/co/elastic/apm/agent/configuration/CoreConfiguration.java
Outdated
Show resolved
Hide resolved
...agent-plugins/apm-api-plugin/src/test/java/co/elastic/apm/api/AnnotationInheritanceTest.java
Outdated
Show resolved
Hide resolved
apm-agent-core/src/main/java/co/elastic/apm/agent/configuration/CoreConfiguration.java
Outdated
Show resolved
Hide resolved
|
@eyalkoren Thank you for updating configuration.asciidoc! |
eyalkoren
left a comment
There was a problem hiding this comment.
Awesome work, thanks @tobiasstadler ! ❤️
I just did a few small cosmetic changes in the tests and removed the method matching check on super-annotated-methods being in classes within the configured application packages as it is not required.
|
Thank You! |
What does this PR do?
Fixes #1773
Checklist