Skip to content

Added support for naming spark transactions (#1893)#1894

Merged
felixbarny merged 6 commits intoelastic:masterfrom
tobiasstadler:fix-1893
Jul 5, 2021
Merged

Added support for naming spark transactions (#1893)#1894
felixbarny merged 6 commits intoelastic:masterfrom
tobiasstadler:fix-1893

Conversation

@tobiasstadler
Copy link
Contributor

@tobiasstadler tobiasstadler commented Jul 1, 2021 •
edited by zube bot
Loading

What does this PR do?

Fixes #1893

Checklist

  • This is an enhancement of existing features, or a new feature in existing plugins
    • I have updated CHANGELOG.asciidoc
    • I have added tests that prove my fix is effective or that my feature works
    • Added an API method or config option? Document in which version this will be introduced
    • I have made corresponding changes to the documentation
@ghost
Copy link

ghost commented Jul 1, 2021 •
edited by ghost
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #1894 event

  • Start Time: 2021-07-05T09:18:47.755+0000

  • Duration: 55 min 35 sec

  • Commit: 36e149c

Test stats 🧪

Test Results
Failed 0
Passed 2309
Skipped 19
Total 2328

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 2309
Skipped 19
Total 2328

felixbarny
felixbarny reviewed Jul 1, 2021
View reviewed changes
Copy link
Member

@felixbarny felixbarny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A short and sweet plugin ❤️
@felixbarny
Copy link
Member

felixbarny commented Jul 5, 2021

Could you execute ConfigurationExporterTest so that the disable_instrumentation config docs gets updated to include sparkjava?
@tobiasstadler
Copy link
Contributor Author

tobiasstadler commented Jul 5, 2021

Could you execute ConfigurationExporterTest so that the disable_instrumentation config docs gets updated to include sparkjava?

Sorry, I forgot that.
@felixbarny felixbarny enabled auto-merge (squash) July 5, 2021 08:29
tobiasstadler
tobiasstadler commented Jul 5, 2021
View reviewed changes
CHANGELOG.asciidoc Outdated
* Instrument javax.servlet.Filter the same way as javax.servlet.FilterChain - {pull}1858[#1858]
* Propagate trace context headers in HTTP calls occurring from within traced exit points, for example - when using
Elasticsearch's REST client - {pull}1883[#1883]
* Instrument javax.servlet.Filter the same way as javax.servlet.FilterChain {pull}1858[#1858]
Copy link
Contributor Author

@tobiasstadler tobiasstadler Jul 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank You!
@felixbarny
Copy link
Member

felixbarny commented Jul 5, 2021

@elasticmachine run elasticsearch-ci/docs
@felixbarny felixbarny merged commit 301f6af into elastic:master Jul 5, 2021
@tobiasstadler tobiasstadler deleted the fix-1893 branch July 5, 2021 10:13
@tobiasstadler
Copy link
Contributor Author

tobiasstadler commented Jul 5, 2021

Thank You!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-java

3 participants

@tobiasstadler @felixbarny @SylvainJuge