Use Implementation-Title as default service name if it is available#1921
Merged
felixbarny merged 40 commits intoelastic:mainfrom Jan 26, 2022
Merged
Use Implementation-Title as default service name if it is available#1921felixbarny merged 40 commits intoelastic:mainfrom
felixbarny merged 40 commits intoelastic:mainfrom
Conversation
Contributor
Author
|
Could someone please have a look? |
Contributor
Author
|
@SylvainJuge Maybe you can spare some time please. |
Member
|
run elasticsearch-ci/docs |
Contributor
Author
|
@felixbarny Maybe you can spare some time please? |
Member
|
Hi @tobiasstadler, we have added this to our short-term backlog. |
Contributor
Author
|
Thank You! I am looking forward to it. |
Merged
2 tasks
c77dc20 to
8b5d38f
Compare
Contributor
Author
|
Any chance this will make it into 1.29.0? |
felixbarny
approved these changes
Jan 26, 2022
Member
felixbarny
left a comment
There was a problem hiding this comment.
This looks pretty straightforward.
It doesn't catch the Implementation-Title from within .war files but a good first step!
Member
|
/test |
Member
|
run elasticsearch-ci/docs |
felixbarny
reviewed
Jan 26, 2022
Co-authored-by: Felix Barnsteiner <felixbarny@users.noreply.github.com>
auto-merge was automatically disabled
January 26, 2022 07:40
Head branch was pushed to by a user without write access
Contributor
|
run elasticsearch-ci/docs |
5 tasks
Contributor
Author
|
Thank You! |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When the MANIFEST.MF of main jar contains the Implementation-Title attribute, it is used as the default service name.
Checklist