Merged
Conversation
github-actions
bot
added
agent-java
community
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
Contributor
|
Thank You! |
SylvainJuge
approved these changes
Jul 27, 2021
Member
SylvainJuge
left a comment
SylvainJuge
left a comment
There was a problem hiding this comment.
LGTM for a quick work-around, we can definitely improve that later if needed.
v1v
added a commit
to v1v/apm-agent-java
that referenced
this pull request
Aug 2, 2021
…junit-support * upstream/master: Updated get-user-teams-membership to version 1.0.3 ensure that the socket is closed even if there is an exception from the other close (elastic#1946) Make sure trace context headers are added only once (elastic#1937) Update CHANGELOG.asciidoc Ecs reformatting more fields (elastic#1910) Use path when high-level framework method is unknown (elastic#1906) Semver parsing enhancement (elastic#1931)
v1v
added a commit
to v1v/apm-agent-java
that referenced
this pull request
Aug 2, 2021
…for-windows-only * upstream/master: (100 commits) [CI] Enable compatibility test matrix for unit tests (elastic#1915) Updated get-user-teams-membership to version 1.0.3 ensure that the socket is closed even if there is an exception from the other close (elastic#1946) Make sure trace context headers are added only once (elastic#1937) Update CHANGELOG.asciidoc Ecs reformatting more fields (elastic#1910) Use path when high-level framework method is unknown (elastic#1906) Semver parsing enhancement (elastic#1931) Bump version.slf4j from 1.7.31 to 1.7.32 (elastic#1933) Add description about memory pool metrics to docs (elastic#1925) updated team membership check in action Add 1.25.0 to cloudfoundry index Update CHANGELOG.asciidoc (elastic#1929) fixed community label action [maven-release-plugin] prepare for next development iteration [maven-release-plugin] prepare release v1.25.0 Prepare release 1.25.0 (elastic#1927) synchronize json schema specs (elastic#1926) added labeling of community issues and PRs added community labeler config ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Closes #1930
A quick and dirty approach, that we can improve later if required.
It looks like using a regex may get quite complicated for this.
If I have more time, I would have made it shorter ( Blaise Pascal)
Checklist