Downloading agent and verifying PGP signature#1959
Merged
eyalkoren merged 13 commits intoelastic:masterfrom Aug 22, 2021
Merged
Downloading agent and verifying PGP signature#1959eyalkoren merged 13 commits intoelastic:masterfrom
eyalkoren merged 13 commits intoelastic:masterfrom
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
SylvainJuge
reviewed
Aug 18, 2021
Member
SylvainJuge
left a comment
There was a problem hiding this comment.
Another question:
Why do we have binary dependencies in the test classpath ? Are they kept in sync through build ?
apm-agent-attach-cli/src/main/java/co/elastic/apm/attach/AgentDownloader.java
Show resolved
Hide resolved
apm-agent-attach-cli/src/main/java/co/elastic/apm/attach/AgentDownloader.java
Outdated
Show resolved
Hide resolved
apm-agent-attach-cli/src/main/java/co/elastic/apm/attach/AgentDownloader.java
Outdated
Show resolved
Hide resolved
apm-agent-attach-cli/src/main/java/co/elastic/apm/attach/PgpSignatureVerifier.java
Outdated
Show resolved
Hide resolved
apm-agent-attach-cli/src/main/java/co/elastic/apm/attach/AgentDownloader.java
Show resolved
Hide resolved
apm-agent-attach-cli/src/main/java/co/elastic/apm/attach/PgpSignatureVerifierLoader.java
Show resolved
Hide resolved
apm-agent-attach-cli/src/main/java/co/elastic/apm/attach/Utils.java
Outdated
Show resolved
Hide resolved
apm-agent-attach-cli/src/test/java/co/elastic/apm/attach/AgentDownloaderTest.java
Outdated
Show resolved
Hide resolved
...tion-tests/src/test/java/co/elastic/apm/servlet/AbstractServletContainerIntegrationTest.java
Show resolved
Hide resolved
SylvainJuge
approved these changes
Aug 18, 2021
Member
SylvainJuge
left a comment
There was a problem hiding this comment.
LGTM, discussed few details live.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Closes #1901
We use the Bouncy Castle FIPS PGP implementation for the jar signature validation.
Since the related Bouncy Castle jars are doing self-checksum validation based on the jar they are coming from, we package them as is in a dedicated lib within the jar, alongside a minimal jar of ours that contains the Bouncy Castle implementation for the internal
BouncyCastleVerifier#verifyPgpSignatureAPI.All these jars are loaded by a dedicated class loader.
Checklist
--helpoutput