deleted encrypted from Socket.#2136
Merged
SylvainJuge merged 3 commits intoelastic:masterfrom Sep 20, 2021
Merged
Conversation
github-actions
bot
added
agent-java
community
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
eyalkoren
reviewed
Sep 19, 2021
Contributor
eyalkoren
left a comment
eyalkoren
left a comment
There was a problem hiding this comment.
Thanks @kananindzya !
One small comment
Comment on lines
30
to
35
| /** | ||
| * Indicates whether request was sent as SSL/HTTPS request. | ||
| */ | ||
| public Socket withEncrypted(boolean encrypted) { | ||
| this.encrypted = encrypted; | ||
| return this; | ||
| } |
Contributor
There was a problem hiding this comment.
Remove method altogether and all its usages if there are still such left (I don't think there are)
eyalkoren
approved these changes
Sep 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2135
Checklist