Introduce async profiler upgrade utility and upgrade to 1.8.7#2165
Introduce async profiler upgrade utility and upgrade to 1.8.7#2165eyalkoren merged 8 commits intoelastic:masterfrom
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
...rofiling-plugin/src/main/java/co/elastic/apm/agent/profiler/asyncprofiler/AsyncProfiler.java
Show resolved
Hide resolved
|
I did not looked at the added unit test details, but what are the benefits over using a test disabled by default over the |
I actually didn't remember we had such 🤦♂️
Since I already spent this time, does it make sense to keep? |
Let's keep the test version then, maybe instead of having a disabled test just a executable entry point so it's not reported as disabled/skipped in reports and it does not require any modification to execute. |
| <dependency> | ||
| <groupId>tools.profiler</groupId> | ||
| <artifactId>async-profiler</artifactId> | ||
| <version>1.8.3</version> |
There was a problem hiding this comment.
[minor] might be worth having a build property to define the version, then reuse this in AsyncProfilerUpgrader to avoid any confusion. Or, maybe simpler if AsyncProfilerUpgrader would be able to extract the version from this dependency at runtimeand remove the AsyncProfilerUpgrader#TARGET_VERSION
There was a problem hiding this comment.
This is the Java API dependency, not the lib itself - you see its version is 1.8.3. We don't need to maintain this unless the API breaks
Co-authored-by: SylvainJuge <syl20j@gmail.com>
What does this PR do?
Introduces a JUnit utility for upgrading async profiler. The test class is disabled by default, and should be invoked manually when an upgrade is required.
In addition, async profiler is upgraded to version 1.8.7, and uses the newly introduced
safemodesetting option through system property.Checklist
AsyncProfiler.safemodesystem property