Skip to content

Support for Java/Jakarta WebSocket ServerEndpoint#2281

Merged
felixbarny merged 29 commits intoelastic:mainfrom
tobiasstadler:websocket-plugin
Jan 28, 2022
Merged

Support for Java/Jakarta WebSocket ServerEndpoint#2281
felixbarny merged 29 commits intoelastic:mainfrom
tobiasstadler:websocket-plugin

Conversation

@tobiasstadler
Copy link
Contributor

What does this PR do?

Adds support for Java/Jakarta WebSocket ServerEndpoint

Checklist

  • This is a new plugin
    • I have updated CHANGELOG.asciidoc
    • My code follows the style guidelines of this project
    • I have made corresponding changes to the documentation
    • I have added tests that prove my fix is effective or that my feature works
    • New and existing unit tests pass locally with my changes
    • I have updated supported-technologies.asciidoc
    • Added an API method or config option? Document in which version this will be introduced
    • Added an instrumentation plugin? Describe how you made sure that old, non-supported versions are not instrumented by accident.
@github-actions
Copy link

👋 @tobiasstadler Thanks a lot for your contribution!

It may take some time before we review a PR, so even if you don’t see activity for some time, it does not mean that we have forgotten about it.

Every once in a while we go through a process of prioritization, after which we are focussing on the tasks that were planned for the upcoming milestone. The prioritization status is typically reflected through the PR labels. It could be pending triage, a candidate for a future milestone, or have a target milestone set to it.

@github-actions github-actions bot added community Issues and PRs created by the community triage labels Nov 23, 2021
@ghost
Copy link

ghost commented Nov 23, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Reason: null

  • Start Time: 2022-01-28T14:44:08.270+0000

  • Duration: 52 min 13 sec

  • Commit: eaab4dd

Test stats 🧪

Test Results
Failed 0
Passed 2468
Skipped 16
Total 2484

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark tests.

  • run jdk compatibility tests : Run the JDK Compatibility tests.

  • run integration tests : Run the Agent Integration tests.

  • run end-to-end tests : Run the APM-ITs.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@tobiasstadler tobiasstadler changed the title Added support for Java/Jakarta WebSocket ServerEndpoint Nov 24, 2021
@SylvainJuge SylvainJuge added the new-feature New feature label Jan 25, 2022
@tobiasstadler
Copy link
Contributor Author

@felixbarny Could you please review this PR also?

@felixbarny felixbarny enabled auto-merge (squash) January 28, 2022 11:02
@felixbarny
Copy link
Member

run elasticsearch-ci/docs

auto-merge was automatically disabled January 28, 2022 11:27

Pull Request is not mergeable

@felixbarny
Copy link
Member

run elasticsearch-ci/docs

@felixbarny felixbarny enabled auto-merge (squash) January 28, 2022 13:59
@felixbarny
Copy link
Member

run elasticsearch-ci/docs

auto-merge was automatically disabled January 28, 2022 14:43

Head branch was pushed to by a user without write access

@felixbarny felixbarny enabled auto-merge (squash) January 28, 2022 14:46
@tobiasstadler
Copy link
Contributor Author

run elasticsearch-ci/docs

1 similar comment
@felixbarny
Copy link
Member

run elasticsearch-ci/docs

@felixbarny felixbarny merged commit 53204c6 into elastic:main Jan 28, 2022
@tobiasstadler tobiasstadler deleted the websocket-plugin branch January 28, 2022 16:48
@tobiasstadler
Copy link
Contributor Author

Thank You!

@felixbarny
Copy link
Member

Thank you too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-java community Issues and PRs created by the community new-feature New feature triage

3 participants