Fix @Traced annotation outcome#2370
Conversation
|
👋 @spinscale Thanks a lot for your contribution! It may take some time before we review a PR, so even if you don’t see activity for some time, it does not mean that we have forgotten about it. Every once in a while we go through a process of prioritization, after which we are focussing on the tasks that were planned for the upcoming milestone. The prioritization status is typically reflected through the PR labels. It could be pending triage, a candidate for a future milestone, or have a target milestone set to it. |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
eyalkoren
left a comment
There was a problem hiding this comment.
Ohh, how silly of us. Thanks!
What does this PR do?
In the current implementation a method annotated with
@Tracednever returns a successful outcome. This commit fixes this to properly check for the existence of an exception. Currently any transaction involving a@Tracedmethod is marked as failed:Checklist