Skip to content

Fix @Traced annotation outcome#2370

Merged
eyalkoren merged 2 commits intoelastic:masterfrom
spinscale:2112-fix-traced-annotation-outcome
Dec 23, 2021
Merged

Fix @Traced annotation outcome#2370
eyalkoren merged 2 commits intoelastic:masterfrom
spinscale:2112-fix-traced-annotation-outcome

Conversation

@spinscale
Copy link
Contributor

@spinscale spinscale commented Dec 23, 2021

What does this PR do?

In the current implementation a method annotated with @Traced never returns a successful outcome. This commit fixes this to properly check for the existence of an exception. Currently any transaction involving a @Traced method is marked as failed:

image

Checklist

  • This is an enhancement of existing features, or a new feature in existing plugins
    • I have updated CHANGELOG.asciidoc
    • I have added tests that prove my fix is effective or that my feature works
    • Added an API method or config option? Document in which version this will be introduced
    • I have made corresponding changes to the documentation
  • This is a bugfix
  • This is a new plugin
    • I have updated CHANGELOG.asciidoc
    • My code follows the style guidelines of this project
    • I have made corresponding changes to the documentation
    • I have added tests that prove my fix is effective or that my feature works
    • New and existing unit tests pass locally with my changes
    • I have updated supported-technologies.asciidoc
    • Added an API method or config option? Document in which version this will be introduced
    • Added an instrumentation plugin? Describe how you made sure that old, non-supported versions are not instrumented by accident.
  • This is something else
@github-actions github-actions bot added agent-java community Issues and PRs created by the community triage labels Dec 23, 2021
@github-actions
Copy link

👋 @spinscale Thanks a lot for your contribution!

It may take some time before we review a PR, so even if you don’t see activity for some time, it does not mean that we have forgotten about it.

Every once in a while we go through a process of prioritization, after which we are focussing on the tasks that were planned for the upcoming milestone. The prioritization status is typically reflected through the PR labels. It could be pending triage, a candidate for a future milestone, or have a target milestone set to it.

@ghost
Copy link

ghost commented Dec 23, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-12-23T14:47:50.453+0000

  • Duration: 67 min 28 sec

  • Commit: 5535452

Test stats 🧪

Test Results
Failed 0
Passed 2635
Skipped 23
Total 2658

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark test.

  • run compatibility tests : Run the JDK Compatibility test.

  • run integration tests : Run the APM-ITs.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Contributor

@eyalkoren eyalkoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh, how silly of us. Thanks!

@eyalkoren eyalkoren enabled auto-merge (squash) December 23, 2021 15:11
@eyalkoren eyalkoren merged commit fe24b26 into elastic:master Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-java community Issues and PRs created by the community triage

2 participants