Implemented AWS lambda spec changes#2424
Merged
AlexanderWert merged 19 commits intoelastic:mainfrom Mar 15, 2022
Merged
Conversation
|
/test |
eyalkoren
reviewed
Mar 6, 2022
Contributor
There was a problem hiding this comment.
Looks good!
Missing:
- Serialization test for
faasfields (id,name,version) - Tests for
faas.nameandfaas.versioncorrectness in the Lambda tests
Let's sort out our transaction naming approach offline and I will make adjustments if required and implement #2305
apm-agent-core/src/test/java/co/elastic/apm/agent/impl/metadata/MetaDataTest.java
Show resolved
Hide resolved
...ambda-plugin/src/main/java/co/elastic/apm/agent/awslambda/RequestHandlerInstrumentation.java
Show resolved
Hide resolved
...ambda-plugin/src/main/java/co/elastic/apm/agent/awslambda/RequestHandlerInstrumentation.java
Show resolved
Hide resolved
.../src/main/java/co/elastic/apm/agent/awslambda/helper/APIGatewayProxyV1TransactionHelper.java
Outdated
Show resolved
Hide resolved
.../src/main/java/co/elastic/apm/agent/awslambda/helper/APIGatewayProxyV1TransactionHelper.java
Outdated
Show resolved
Hide resolved
This was
linked to
issues
Mar 7, 2022
eyalkoren
reviewed
Mar 8, 2022
.../src/main/java/co/elastic/apm/agent/awslambda/helper/APIGatewayProxyV1TransactionHelper.java
Outdated
Show resolved
Hide resolved
felixbarny
reviewed
Mar 14, 2022
apm-agent-core/src/main/java/co/elastic/apm/agent/report/IntakeV2ReportingEventHandler.java
Show resolved
Hide resolved
apm-agent-core/src/main/java/co/elastic/apm/agent/report/ApmServerReporter.java
Show resolved
Hide resolved
AlexanderWert
commented
Mar 14, 2022
Member
Author
AlexanderWert
left a comment
There was a problem hiding this comment.
I reviewed the changes.
Except a small bug, that I found in my own code, everything looks good.
Tested the interplay with the extension: The extension receives the flush=true signal as expected. So all good on that side as well.
apm-agent-core/src/test/java/co/elastic/apm/agent/report/IntakeV2ReportingEventHandlerTest.java
Show resolved
Hide resolved
...gin/src/main/java/co/elastic/apm/agent/awslambda/helper/AbstractLambdaTransactionHelper.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Alexander Wert <AlexanderWert@users.noreply.github.com>
felixbarny
reviewed
Mar 14, 2022
apm-agent-core/src/main/java/co/elastic/apm/agent/report/IntakeV2ReportingEventHandler.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
transaction.namefor API Gateway-triggered Lambda functions: To be consistent with other HTTP-based instrumentations include the low-cardinality resourcePath into the name.use_path_as_transaction_name: Ifuse_path_as_transaction_nameis enabled use the full HTTP path for thetransaction.namein API Gateway-triggered Lambda functions.service_nameandservice_versionagent config options: Ifservice_nameand/orservice_versionare explicitly configured use the configured values instead of the derived ones.service.origin.nameservice.idmetadata field with new transaction-level fieldfaas.id: To being able to capture different Lambda function ARN values (semantically correct) under one APM service umbrella (for the scenario of consolidating multiple lambda functions in one APM service).flushed=truequery param on Lambda data flush ([META 569] Add query param flushed=true to final intake request at the end of lambda function #2305)experimentalflag from the Lambda featureenable_instrumentations, increasing timeout, increasing heap size