Skip to content

WebSocket requests should be captured with transaction type request#2501

Merged
SylvainJuge merged 2 commits intoelastic:mainfrom
tobiasstadler:websocket-transaction-type-request
Mar 18, 2022
Merged

WebSocket requests should be captured with transaction type request#2501
SylvainJuge merged 2 commits intoelastic:mainfrom
tobiasstadler:websocket-transaction-type-request

Conversation

@tobiasstadler
Copy link
Contributor

What does this PR do?

WebSocket requests should be captured with transaction type request instead of custom.

Checklist

  • This is a bugfix
@github-actions github-actions bot added agent-java community Issues and PRs created by the community triage labels Mar 8, 2022
@github-actions
Copy link

github-actions bot commented Mar 8, 2022

👋 @tobiasstadler Thanks a lot for your contribution!

It may take some time before we review a PR, so even if you don’t see activity for some time, it does not mean that we have forgotten about it.

Every once in a while we go through a process of prioritization, after which we are focussing on the tasks that were planned for the upcoming milestone. The prioritization status is typically reflected through the PR labels. It could be pending triage, a candidate for a future milestone, or have a target milestone set to it.

@ghost
Copy link

ghost commented Mar 8, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-03-18T12:40:15.990+0000

  • Duration: 45 min 39 sec

Test stats 🧪

Test Results
Failed 0
Passed 2744
Skipped 16
Total 2760

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark tests.

  • run jdk compatibility tests : Run the JDK Compatibility tests.

  • run integration tests : Run the Agent Integration tests.

  • run end-to-end tests : Run the APM-ITs.

  • run windows tests : Build & tests on windows.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@tobiasstadler
Copy link
Contributor Author

@felixbarny Would please have a look?

@SylvainJuge SylvainJuge added the bug Bugs label Mar 18, 2022
@SylvainJuge
Copy link
Member

/test

@tobiasstadler
Copy link
Contributor Author

@SylvainJuge Could you please restart the tests?

@SylvainJuge
Copy link
Member

@elasticmachine run elasticsearch-ci/docs

@SylvainJuge SylvainJuge enabled auto-merge (squash) March 18, 2022 14:18
@SylvainJuge SylvainJuge merged commit 71251b5 into elastic:main Mar 18, 2022
@tobiasstadler
Copy link
Contributor Author

Thank You!

@tobiasstadler tobiasstadler deleted the websocket-transaction-type-request branch March 18, 2022 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-java bug Bugs community Issues and PRs created by the community

2 participants