Skip to content

Create a span for a nested action invocation via chain result#2513

Merged
felixbarny merged 12 commits intoelastic:mainfrom
tobiasstadler:struts-chain-result-span
May 18, 2022
Merged

Create a span for a nested action invocation via chain result#2513
felixbarny merged 12 commits intoelastic:mainfrom
tobiasstadler:struts-chain-result-span

Conversation

@tobiasstadler
Copy link
Contributor

What does this PR do?

If the result of an action invocation is a action chain, start a new span for the new action invocation.

Checklist

  • This is an enhancement of existing features, or a new feature in existing plugins
    • I have updated CHANGELOG.asciidoc
    • I have added tests that prove my fix is effective or that my feature works
    • Added an API method or config option? Document in which version this will be introduced
    • I have made corresponding changes to the documentation
@github-actions github-actions bot added agent-java community Issues and PRs created by the community triage labels Mar 15, 2022
@github-actions
Copy link

👋 @tobiasstadler Thanks a lot for your contribution!

It may take some time before we review a PR, so even if you don’t see activity for some time, it does not mean that we have forgotten about it.

Every once in a while we go through a process of prioritization, after which we are focussing on the tasks that were planned for the upcoming milestone. The prioritization status is typically reflected through the PR labels. It could be pending triage, a candidate for a future milestone, or have a target milestone set to it.

@tobiasstadler
Copy link
Contributor Author

@eyalkoren Would you mind having a look please?

@ghost
Copy link

ghost commented Mar 15, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-18T07:16:17.460+0000

  • Duration: 47 min 22 sec

Test stats 🧪

Test Results
Failed 0
Passed 2873
Skipped 22
Total 2895

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark tests.

  • run jdk compatibility tests : Run the JDK Compatibility tests.

  • run integration tests : Run the Agent Integration tests.

  • run end-to-end tests : Run the APM-ITs.

  • run windows tests : Build & tests on windows.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@SylvainJuge SylvainJuge added enhancement Enhancement of an existing feature and removed triage labels Mar 18, 2022
@tobiasstadler
Copy link
Contributor Author

ping

@SylvainJuge
Copy link
Member

Hi @tobiasstadler !

We haven't forgotten about this PR, but there was quite a few more urgent things to deal with, part of the team (me included) will be on PTO in the following weeks, so it's very hard to give you an ETA on this.

@tobiasstadler
Copy link
Contributor Author

ping

Copy link
Member

@felixbarny felixbarny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like a useful, simple and non-contentious enhancement

@felixbarny
Copy link
Member

/test

@felixbarny felixbarny enabled auto-merge (squash) May 18, 2022 07:15
@felixbarny
Copy link
Member

run elasticsearch-ci/docs

@felixbarny felixbarny merged commit 19390d8 into elastic:main May 18, 2022
@tobiasstadler tobiasstadler deleted the struts-chain-result-span branch May 18, 2022 08:13
@tobiasstadler
Copy link
Contributor Author

Thank You!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-java community Issues and PRs created by the community enhancement Enhancement of an existing feature

3 participants