Skip to content

Support for setting the service version on Log4j2's EcsLayout#2604

Merged
felixbarny merged 6 commits intoelastic:mainfrom
tobiasstadler:ecs-logging-service-version
May 4, 2022
Merged

Support for setting the service version on Log4j2's EcsLayout#2604
felixbarny merged 6 commits intoelastic:mainfrom
tobiasstadler:ecs-logging-service-version

Conversation

@tobiasstadler
Copy link
Contributor

What does this PR do?

Adds support for setting the service version on Log4j2's EcsLayout

Checklist

  • This is an enhancement of existing features, or a new feature in existing plugins
    • I have updated CHANGELOG.asciidoc
    • I have added tests that prove my fix is effective or that my feature works
    • Added an API method or config option? Document in which version this will be introduced
    • I have made corresponding changes to the documentation
@github-actions github-actions bot added agent-java community Issues and PRs created by the community triage labels May 2, 2022
@github-actions
Copy link

github-actions bot commented May 2, 2022

👋 @tobiasstadler Thanks a lot for your contribution!

It may take some time before we review a PR, so even if you don’t see activity for some time, it does not mean that we have forgotten about it.

Every once in a while we go through a process of prioritization, after which we are focussing on the tasks that were planned for the upcoming milestone. The prioritization status is typically reflected through the PR labels. It could be pending triage, a candidate for a future milestone, or have a target milestone set to it.

@ghost
Copy link

ghost commented May 2, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-04T07:55:23.510+0000

  • Duration: 45 min 8 sec

Test stats 🧪

Test Results
Failed 0
Passed 2861
Skipped 22
Total 2883

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark tests.

  • run jdk compatibility tests : Run the JDK Compatibility tests.

  • run integration tests : Run the Agent Integration tests.

  • run end-to-end tests : Run the APM-ITs.

  • run windows tests : Build & tests on windows.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@felixbarny
Copy link
Member

run elasticsearch-ci/docs

@felixbarny felixbarny enabled auto-merge (squash) May 4, 2022 06:40
@felixbarny felixbarny merged commit c558ad4 into elastic:main May 4, 2022
@tobiasstadler
Copy link
Contributor Author

tobiasstadler commented May 4, 2022

Thank You!

@tobiasstadler tobiasstadler deleted the ecs-logging-service-version branch May 4, 2022 08:45
@SylvainJuge SylvainJuge added await-release Mark issues that depend on next release, or PRs that are planned to be included and removed triage await-release Mark issues that depend on next release, or PRs that are planned to be included labels May 5, 2022
videnkz pushed a commit to videnkz/apm-agent-java that referenced this pull request May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-java community Issues and PRs created by the community

3 participants