Merged
Conversation
Closed
felixbarny
approved these changes
May 16, 2022
Member
felixbarny
left a comment
There was a problem hiding this comment.
LGTM, I like the simpler approach of instrumenting just one entry point instead of all the command method implementations!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Closes #2616
The proposed instrumentation hereby seems simpler and is more suitable for easily supporting Jedis 4 as well.
All existing tests pass, so I can't say if I missed anything with this simplification.
Checklist
Added an API method or config option? Document in which version this will be introduced